Skip to content

fix(auth-core): Improve auth-core quality#1794

Merged
gtema merged 1 commit into
mainfrom
auth-core
Jun 16, 2026
Merged

fix(auth-core): Improve auth-core quality#1794
gtema merged 1 commit into
mainfrom
auth-core

Conversation

@gtema

@gtema gtema commented Jun 15, 2026

Copy link
Copy Markdown
Owner
  • Implement AuthTokenScope::matches() for wildcard cache lookup (None
    matches any value)
  • Update get_scope_auth/find_scope_authz to iterate with matches()
    instead of HashMap::get
  • Remove custom Serialize for Project/Domain; remove skip_serializing_if
    for postcard compat
  • Rename AuthResponse::token field type from AuthToken to TokenInfo
  • Change OpenStackAuthType::auth trait signature to take &HashMap
    (borrow instead of owned)
  • Rename AuthToken::set_header return type from Result<&'a mut
    HeaderMap> to Result<()>
  • Improve from_reqwest_response error handling for non-JSON and identity
    API errors
  • Update httpmock JSON expectations to include explicit null fields
  • Fix AuthError variants: box AuthReceiptResponse, wrap AuthTokenError
    in Auth::AuthToken
  • Fix federation and websso callback server test race conditions with
    oneshot channels
  • Add 18 AuthTokenScope::matches() tests and 9 state cache tests
  • Reorder struct fields alphabetically per project standards

- Implement AuthTokenScope::matches() for wildcard cache lookup (None
  matches any value)
- Update get_scope_auth/find_scope_authz to iterate with matches()
  instead of HashMap::get
- Rename AuthResponse::token field type from AuthToken to TokenInfo
- Change OpenStackAuthType::auth trait signature to take &HashMap
  (borrow instead of owned)
- Rename AuthToken::set_header return type from Result<&'a mut
  HeaderMap> to Result<()>
- Improve from_reqwest_response error handling for non-JSON and identity
  API errors
- Fix federation and websso callback server test race conditions with
  oneshot channels
- Add 18 AuthTokenScope::matches() tests and 9 state cache tests
- Reorder struct fields alphabetically per project standards
@gtema gtema merged commit 123d80b into main Jun 16, 2026
20 checks passed
@gtema-release-plz gtema-release-plz Bot mentioned this pull request Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant