Skip to content

refactor: Improve auth plugins#1796

Merged
gtema merged 1 commit into
mainfrom
auth
Jun 18, 2026
Merged

refactor: Improve auth plugins#1796
gtema merged 1 commit into
mainfrom
auth

Conversation

@gtema

@gtema gtema commented Jun 17, 2026

Copy link
Copy Markdown
Owner
  • Add plugin anchors to auth crates via build.rs
  • Remove direct plugin anchoring from openstack.rs/openstack_async.rs
  • Improve docstrings across all auth plugins
  • Fix critical bug: auth-oidcaccesstoken was never sending access_token
  • Auth plugins now require ANCHOR static for linker anchoring
  • Remove direct 'use openstack_sdk_auth_* as _' from openstack.rs and
    openstack_async.rs
  • Add plugin_anchors module to lib.rs for generated anchors
  • Module-level docs describing the auth flow (with numbered steps where
    applicable)
  • Struct-level docs on *Authenticator structs
  • Properly named error enums (replaced generic 'Token related errors')
  • auth-oidcaccesstoken: 7 tests (previously 0) - success + missing
    values + helper
  • auth-jwt: 9 tests (previously 0) - success + missing values + API
    version
  • auth-password: 4 new error-path tests
  • auth-token: 2 new missing-token error path tests
  • auth-totp: 6 new tests (error paths + auth flows)
  • auth-application-credential: 4 new tests (name+user flow + error
    paths)
  • auth-core: 1 new anchor_plugins test

@gtema gtema force-pushed the auth branch 2 times, most recently from 09d7163 to d23def6 Compare June 17, 2026 13:23
Comment thread sdk/auth-federation/src/lib.rs Fixed
Comment thread sdk/auth-websso/src/lib.rs Fixed
Comment thread sdk/auth-websso/src/lib.rs Fixed
- Add plugin anchors to auth crates via build.rs
- Remove direct plugin anchoring from openstack.rs/openstack_async.rs
- Improve docstrings across all auth plugins
- Fix critical bug: auth-oidcaccesstoken was never sending access_token
- Auth plugins now require ANCHOR static for linker anchoring
- Remove direct 'use openstack_sdk_auth_* as _' from openstack.rs and
  openstack_async.rs
- Add plugin_anchors module to lib.rs for generated anchors
- Module-level docs describing the auth flow (with numbered steps where
  applicable)
- Struct-level docs on *Authenticator structs
- Properly named error enums (replaced generic 'Token related errors')
- auth-oidcaccesstoken: 7 tests (previously 0) - success + missing
  values + helper
- auth-jwt: 9 tests (previously 0) - success + missing values + API
  version
- auth-password: 4 new error-path tests
- auth-token: 2 new missing-token error path tests
- auth-totp: 6 new tests (error paths + auth flows)
- auth-application-credential: 4 new tests (name+user flow + error
  paths)
- auth-core: 1 new anchor_plugins test
@gtema gtema merged commit 98fe87f into main Jun 18, 2026
24 checks passed
@gtema-release-plz gtema-release-plz Bot mentioned this pull request Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants