Use native Preferences toolbar symbols and synchronize tab selection - #22
Draft
MiMoHo wants to merge 1 commit into
Draft
Use native Preferences toolbar symbols and synchronize tab selection#22MiMoHo wants to merge 1 commit into
MiMoHo wants to merge 1 commit into
Conversation
Related to haad#20. AI assistance: Hermes Agent, gpt-6-astra. Reasoning effort: not exposed by this session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use native, template-rendered symbols for the Preferences toolbar and keep its selected item aligned with programmatic tab changes.
Related: #20 updates the menu-bar icon and Appearance controls. This change does not convert the main NIB to XIB, change privacy-control wording, or alter permission requests.
Verification
Four regression tests pass, covering the repository’s actual tab identifiers and native AppKit symbol/template properties, programmatic tab/toolbar synchronization, removal of obsolete icons, and Xcode object-reference integrity. The Xcode project parses successfully and the scoped diff is whitespace-clean.
Limits
Draft pending a full Xcode project build and maintainer visual acceptance on supported macOS versions. Native isolated tests are not a newly installed app or a permission test.
AI assistance
Implemented and independently reviewed with Hermes Agent using gpt-6-astra. The session does not expose its reasoning-effort setting; no value is inferred.