test: lock v1 schema sync and CCM recommendation prompt defaults - #950
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add schema-bundle contract assertions for template inputs openness, RuntimeV1 delegate selectors, and TemplateContainerOverlay from the harness-schema auto-sync. Extend the business-value-review prompt test so Open-tab days_back/min_saving and Applied-tab date semantics stay documented for agents. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regression-test coverage for recent merged changes (triggered while reviewing PR #949; production diff there is version-only). Locks in harness-schema auto-sync (#943) contract and CCM Open-tab recommendation guidance from #948.
Risky behavior now covered
inputsopenness — prevents reverting to a strictNGVariableV1Wrapperref that rejects valid template input metadata.delegateon object runtime — inherit-from-delegate K8s auth stays in the bundled schema agents use viaharness_schema.TemplateRef.container/TemplateContainerOverlay— caller-side container overrides remain in the public v1 pipeline/template schema.days_back=4,min_saving=1, andapplied_at_*semantics so agents do not map the UI date picker todays_back.Test files added/updated
tests/schemas/schema-bundle-contract.test.ts— three new contract teststests/prompts/business-value-review.test.ts— Open-tab / Applied-tab recommendation defaultsWhy these tests materially reduce regression risk
Schema auto-sync is machine-generated and easy to regress silently; contract tests fail CI if upstream fields disappear. The prompt test guards FinOps/BVR flows that depend on CCM list/stats matching the UI Open tab — a common source of inflated savings figures.
Type of Change
Checklist
pnpm testpasses (targeted: schema-bundle-contract + business-value-review)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses