Fix import from server selection not updating with new values when new file has been added on the server#735
Open
correct-horse-battery-bench wants to merge 2 commits into
Conversation
…validate and firstValueFrom in this case returns the cached value instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During hashlist creation with import from server, the list of files to select only updates with new files that might have been added to the server only when the user logs out.
The issue is that certain requests are cached and 'firstValueFrom' only returns the cached value.
Use lastValueFrom in this case. Also later investigate if we can circumvent this problem in general instead of this targeted fix.
Issue: hashtopolis/server#2271