Skip to content

Add build with std::any and std::optional#1693

Merged
andrey-kashcheev merged 2 commits intomasterfrom
rga/porting-std
Apr 27, 2026
Merged

Add build with std::any and std::optional#1693
andrey-kashcheev merged 2 commits intomasterfrom
rga/porting-std

Conversation

@rustam-gamidov-here
Copy link
Copy Markdown
Collaborator

boost::any and boost::optional used by default and it make sense to check that alternative options are not broken

Relates-To: MINOR

@rustam-gamidov-here rustam-gamidov-here force-pushed the rga/porting-std branch 2 times, most recently from cf9deb1 to 3a0c7c1 Compare April 23, 2026 13:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.29%. Comparing base (ba64a86) to head (bfb643f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...-cpp-sdk-dataservice-write/src/CatalogSettings.cpp 0.00% 0 Missing and 1 partial ⚠️
...dk-dataservice-write/src/StreamLayerClientImpl.cpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1693      +/-   ##
==========================================
- Coverage   80.32%   80.29%   -0.03%     
==========================================
  Files         356      356              
  Lines       14280    14279       -1     
  Branches     1565     1565              
==========================================
- Hits        11470    11465       -5     
- Misses       2180     2185       +5     
+ Partials      630      629       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rustam-gamidov-here rustam-gamidov-here force-pushed the rga/porting-std branch 6 times, most recently from 59e8409 to c8bd069 Compare April 24, 2026 10:57
boost::any and boost::optional used by default and it make sense
to check that alternative options are not broken

Relates-To: MINOR

Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
This allows to use either std for newer c++ or boost for older c++
or those who prefer boost

Relates-To: MINOR
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
@rustam-gamidov-here rustam-gamidov-here marked this pull request as ready for review April 24, 2026 12:02
@rustam-gamidov-here
Copy link
Copy Markdown
Collaborator Author

assuming it's not needed, thus closing

@rustam-gamidov-here rustam-gamidov-here deleted the rga/porting-std branch April 27, 2026 12:48
@andrey-kashcheev andrey-kashcheev restored the rga/porting-std branch April 27, 2026 12:51
@andrey-kashcheev andrey-kashcheev merged commit 7c1dccc into master Apr 27, 2026
46 checks passed
@andrey-kashcheev andrey-kashcheev deleted the rga/porting-std branch April 27, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants