ci: gate releases on the acceptance suite via a reusable workflow - #328
Open
leggetter wants to merge 1 commit into
Open
ci: gate releases on the acceptance suite via a reusable workflow#328leggetter wants to merge 1 commit into
leggetter wants to merge 1 commit into
Conversation
Extract the acceptance jobs into a reusable workflow (workflow_call) and call it from both test-acceptance.yml (PR) and release.yml. In release.yml the build jobs now needs:[acceptance], so builds and the npm publish only run if acceptance passes on the tagged commit. Re-run failed jobs recovers from transient failures without re-tagging. Closes #326. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQV9qtvETd62qg2iDRR6kY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate the release on the acceptance suite (#326 task 2, following the flake fix in #327). A release now publishes only if acceptance passes on the tagged commit.
How
Extracts the acceptance jobs into a reusable workflow (
.github/workflows/acceptance.yml,workflow_call) so they aren't duplicated:test-acceptance.yml(on PR) now calls it.release.ymladds anacceptancejob that calls it, andbuild-mac/build-linux/build-windows(and thereforepublish-npm)needs:it.So on a tag push: acceptance runs first → builds + npm publish only run if it's green. On a transient failure, Re-run failed jobs re-runs acceptance and proceeds if green — no re-tag needed.
Validation
This PR's own acceptance run exercises the new reusable workflow via the PR path, so a broken reusable conversion would surface here before it ever gates a release. The release path calls the same reusable workflow.
Notes
invocation_id/retry flake, and "Re-run failed jobs" covers residual transient failures.unit-testonly), so the reusable-workflow check-name change doesn't affect merge gating.Closes #326.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UQV9qtvETd62qg2iDRR6kY