fix: Navigate to the dashboard listing page after deleting a dashboard#2444
Conversation
🦋 Changeset detectedLatest commit: cb8e3e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile SummaryThis PR fixes post-delete navigation on the dashboard detail page, changing the redirect from
Confidence Score: 5/5Safe to merge — the change is a single-line route correction with a dedicated E2E test verifying the new behavior. The diff touches exactly one application line (the redirect target after deletion) and adds a focused E2E test that validates both the URL and the listing-page state. No logic, data handling, or auth paths are altered. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant U as User
participant D as DBDashboardPage
participant R as Router
U->>D: Click three-dot menu → Delete Dashboard
D->>D: deleteDashboard.mutate(dashboard.id)
Note over D: Before: router.push('/dashboards')
Note over D: After: router.push('/dashboards/list')
D->>R: onSuccess callback
R-->>U: Navigate to /dashboards/list
Reviews (3): Last reviewed commit: "Merge branch 'main' into cursor/navigate..." | Re-trigger Greptile |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
E2E Test Results✅ All tests passed • 202 passed • 3 skipped • 1297s
Tests ran across 4 shards in parallel. |
Change post-delete navigation from /dashboards (temporary dashboard) to /dashboards/list (listing page). Add deleteDashboard method to the DashboardPage page object and an E2E test verifying the behavior. Co-authored-by: Drew Davis <pulpdrew@gmail.com>
71235ce to
5000238
Compare
Summary
When deleting a dashboard from the dashboard detail page (via the three-dot menu), the user was incorrectly navigated to the temporary dashboard page (
/dashboards). This changes the post-delete navigation to redirect to the dashboard listing page (/dashboards/list) instead, which is consistent with the breadcrumbs and app navigation.How to test on Vercel preview
Create a dashboard, then delete it and note that you are now navigated to the dashboards listing page.
References
Linear Issue: HDX-4529