Skip to content

fix: Navigate to the dashboard listing page after deleting a dashboard#2444

Merged
kodiakhq[bot] merged 2 commits into
mainfrom
cursor/navigate-to-listing-after-delete-5b75
Jun 11, 2026
Merged

fix: Navigate to the dashboard listing page after deleting a dashboard#2444
kodiakhq[bot] merged 2 commits into
mainfrom
cursor/navigate-to-listing-after-delete-5b75

Conversation

@pulpdrew

@pulpdrew pulpdrew commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

When deleting a dashboard from the dashboard detail page (via the three-dot menu), the user was incorrectly navigated to the temporary dashboard page (/dashboards). This changes the post-delete navigation to redirect to the dashboard listing page (/dashboards/list) instead, which is consistent with the breadcrumbs and app navigation.

How to test on Vercel preview

Create a dashboard, then delete it and note that you are now navigated to the dashboards listing page.

References

  • Linear Issue: Closes HDX-4529

Linear Issue: HDX-4529

Open in Web Open in Cursor 

@changeset-bot

changeset-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: cb8e3e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hyperdx-oss Ignored Ignored Preview Jun 11, 2026 1:42pm
hyperdx-storybook Ignored Ignored Preview Jun 11, 2026 1:42pm

Request Review

@pulpdrew pulpdrew changed the title Navigate to the dashboard listing page after deleting a dashboard fix: Navigate to the dashboard listing page after deleting a dashboard Jun 11, 2026
@greptile-apps

greptile-apps Bot commented Jun 11, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes post-delete navigation on the dashboard detail page, changing the redirect from /dashboards (the temporary dashboard route) to /dashboards/list (the persistent listing page) and adds an E2E test to cover the behavior.

  • DBDashboardPage.tsx: One-line change replacing router.push('/dashboards') with router.push('/dashboards/list') in the delete onSuccess handler.
  • DashboardPage.ts: Adds a deleteDashboardMenuItem locator and deleteDashboard() page-object helper to support the new E2E test.
  • dashboard.spec.ts: Adds a @full-stack E2E test that creates a dashboard, deletes it via the three-dot menu, and asserts both the URL and that the card is gone from the listing.

Confidence Score: 5/5

Safe to merge — the change is a single-line route correction with a dedicated E2E test verifying the new behavior.

The diff touches exactly one application line (the redirect target after deletion) and adds a focused E2E test that validates both the URL and the listing-page state. No logic, data handling, or auth paths are altered.

No files require special attention.

Important Files Changed

Filename Overview
packages/app/src/DBDashboardPage.tsx Single-line fix: post-delete navigation target corrected from /dashboards to /dashboards/list.
packages/app/tests/e2e/features/dashboard.spec.ts New @full-stack E2E test covering post-delete navigation; steps are well-structured and assertions match the fix.
packages/app/tests/e2e/page-objects/DashboardPage.ts Adds deleteDashboardMenuItem locator and deleteDashboard() helper; locator matches the menu item text exactly as rendered in the component.
.changeset/giant-waves-argue.md Correct patch changeset entry for the @hyperdx/app package.

Sequence Diagram

sequenceDiagram
    participant U as User
    participant D as DBDashboardPage
    participant R as Router

    U->>D: Click three-dot menu → Delete Dashboard
    D->>D: deleteDashboard.mutate(dashboard.id)
    Note over D: Before: router.push('/dashboards')
    Note over D: After:  router.push('/dashboards/list')
    D->>R: onSuccess callback
    R-->>U: Navigate to /dashboards/list
Loading

Reviews (3): Last reviewed commit: "Merge branch 'main' into cursor/navigate..." | Re-trigger Greptile

@pulpdrew pulpdrew marked this pull request as ready for review June 11, 2026 11:52
@pulpdrew pulpdrew added automerge ai-generated AI-generated content; review carefully before merging. labels Jun 11, 2026
@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Jun 11, 2026
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 2 (+ 39 in test files, excluded from tier calculation)
  • Branch: cursor/navigate-to-listing-after-delete-5b75
  • Author: pulpdrew

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

All tests passed • 202 passed • 3 skipped • 1297s

Status Count
✅ Passed 202
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

Change post-delete navigation from /dashboards (temporary dashboard) to
/dashboards/list (listing page). Add deleteDashboard method to the
DashboardPage page object and an E2E test verifying the behavior.

Co-authored-by: Drew Davis <pulpdrew@gmail.com>
@kodiakhq kodiakhq Bot merged commit 712ba11 into main Jun 11, 2026
19 checks passed
@kodiakhq kodiakhq Bot deleted the cursor/navigate-to-listing-after-delete-5b75 branch June 11, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated AI-generated content; review carefully before merging. automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants