Guard the About screen against a crash when no app can open a link#132
Open
jim-daf wants to merge 1 commit into
Open
Guard the About screen against a crash when no app can open a link#132jim-daf wants to merge 1 commit into
jim-daf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping a link in the About WebView can crash the screen.
shouldOverrideUrlLoadingforwards every URL tostartActivity(ACTION_VIEW, ...), and when no installed app can handle the scheme that call throwsActivityNotFoundException.This wraps the launch in a try/catch. When nothing can open the link the user gets a short toast instead of a crash, and normal links keep working as before.
Closes #131