fix: add float() casts in ROS geometry_msgs coordinate conversion functions#159
Open
thueljules wants to merge 1 commit into
Open
fix: add float() casts in ROS geometry_msgs coordinate conversion functions#159thueljules wants to merge 1 commit into
thueljules wants to merge 1 commit into
Conversation
ROS 2 geometry_msgs fields assert float values; ProjectAirSim delivers pose/position data as int, causing AssertionError at runtime. Wrap every numeric component in float() in to_ros_point, to_ros_position_vector3, to_ros_position_list2list, to_ros_quaternion, and to_ros_quaternion_list2list.
Collaborator
|
This is awesome! Thanks for your contribution @thueljules 🦾 Is this already for review, or is it a WIP? Because I see the test plan's checkboxes still empty. |
Author
|
I've run it on my side, but I thought maybe someone should try it before merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan