Fix 404 image on dev and staging#2185
Open
adriendupuis wants to merge 3 commits into
Open
Conversation
adriendupuis
commented
Oct 24, 2023
4f9509d to
e8ff3a4
Compare
# Conflicts: # theme/404.html
|
Preview of modified files: no change to preview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production status
404 page's image works on production thanks to a redirection
PR preview status
On a PR preview, the redirection doesn't exist:
CSS and JS are not loaded because several URLs use a wrong path with
latestinstead of the PR number.Local status
Locally, the redirection doesn't exist:
Fixes
/en/latest/by/en/<PR#>in every URLs, and reloading the JS files.For example, compare current PR 404 to another PR 404
Checklist