docs: cover the POT file in the pup zip migration - #13
Open
jonwaldstein wants to merge 1 commit into
Open
Conversation
The migration lost GiveWP core's POT file and nothing reported it. pup has no POT generation, and `pup i18n` looks like the equivalent while doing something else entirely: it downloads finished translations from GlotPress. With no i18n section in .puprc it exits immediately and still reports success, so the zip ships an empty languages directory and every step is green. The guide told the reader to leave the i18n input at its default, which is exactly the advice that produced this. Add the check to Phase 1, the additional_commands step to Phase 2, and an artifact check to Phase 3. Every impress-org repo shipped a POT as of the core migration, so this would otherwise repeat for each add-on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GiveWP core migrated to the pup zip workflow in impress-org/givewp#8291 and silently stopped shipping
languages/give.pot. Nothing failed — every step reported success.generate-zip.ymlhad an explicitGenerate pot filestep. pup has no equivalent, and nothing in the shared StellarWP workflow replaces it.pup i18nlooks like the equivalent but downloads finished translations from a GlotPress instance rather than generating a POT from source, and with noi18nsection in.puprcit exits immediately:The artifact from that run has a
languages/directory containing only.gitkeep. The 4.16.7.1 zip on WordPress.org, still built byrelease.yml, has a 904,160 bytegive.pot.This guide contributed to it. The only mention of i18n was:
"Leave them at their defaults" is precisely the advice that loses the POT.
What changed
generate-zip.ymlproduced.pup i18nactually does, with theadditional_commandsblock to add. It goes there because the shared workflow runsadditional_commandsafterpup buildand beforepup package, which is the only window where the generated file gets picked up.The fix on the core side is impress-org/givewp#8299, verified: the artifact POT is byte-identical to the one WordPress.org ships apart from the
POT-Creation-Dateheader, 6,434 msgids either way.Note for whoever migrates the add-ons
Every impress-org repo ships a POT today — 26 of them have a
sync-translations.ymlcaller, and the oldgenerate-zip.ymlgenerated one for each. Without this, the migration repeats the same silent loss per repo.If enough add-ons end up carrying the same
additional_commandsstring, an optional POT input onstellarwp/github-actions'zip.ymlwould be worth proposing upstream — WP-CLI is already installed there. Not yet, though: TEC ships.po/.mopulled from GlotPress and no POT template at all, so there's currently no consumer for it outside impress-org.🤖 Generated with Claude Code
https://claude.ai/code/session_018jugbB3kEcQbDRzWuKfHLr
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.