Resolve flagged Rust and npm dependency CVEs#72
Merged
Conversation
Bumps russh from 0.60.3 to 0.61.2 (CVE-2026-46705, CVE-2026-48107, CVE-2026-48108 — all gated by the >=0.61.0 fix) and adds a pnpm override forcing js-yaml >=4.2.0 <5 to remediate CVE-2026-53550 transitively under Astro. 5.x dropped the default export that Astro relies on, so the 4.x line stays for now. pnpmDeps.hash refreshed in nix/packages.nix to match the new pnpm-lock.yaml. Generated with [Indent](https://indent.com) Co-Authored-By: Indent <noreply@indent.com>
Coverage
|
johannkm
approved these changes
Jun 25, 2026
pcarrier
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
russh0.60.3 → 0.61.2 incrates/ssh/Cargo.toml, remediating CVE-2026-46705, CVE-2026-48107, CVE-2026-48108. No API drift —blit-sshbuilds clean against 0.61.pnpm.overrides"js-yaml": ">=4.2.0 <5"injs/pnpm-workspace.yaml, lifting the transitive js-yaml pulled byastro@6.4.8/@astrojs/internal-helperspast the CVE-2026-53550 cutoff (<=4.1.1). Lockfile now resolves js-yaml 4.2.0.pnpmDeps.hashinnix/packages.nixtosha256-OdDAEf61IKfbNKowlp4J5VDICuuHntEN/XzsH5wjZw0=to match the newjs/pnpm-lock.yaml(otherwise every Nix-built CI job fails withhash mismatch in fixed-output derivation, per/memories/repos/indent-com@blit/conventions/pnpm-deps-nix-hash.md).Motivation
Security dashboard flagged
rust-russh0.34.0-beta.1..0.61.0 (three CVEs) andnpm-js-yaml <=4.1.1(CVE-2026-53550) as needing remediation.Testing
cargo build -p blit-ssh✓cargo check -p blit-proxy✓ (other ssh-consuming crates exercise the russh 0.61 API)cargo test -p blit-ssh✓ (no tests, but compiles)cd js/website && pnpm exec astro check✓ (28 files, 0 errors)nix build .#pnpmDeps✓ — verified the hash before committing.js-yaml: why 4.2.0 instead of 5.x
I first tried
js-yaml: ">=5.1.0"(5.x is the long-term target per the user's framing of "upgrade to 5.x in both repos"). It immediately broke Astro:js-yaml5.0 dropped the default export.@astrojs/internal-helpers@0.10.0(transitive underastro@6.4.8) still doesimport yaml from "js-yaml", so 5.x is blocked until Astro adopts the named-only API. 4.2.0 is the immediate patched release inside the 4.x line and is enough to clear CVE-2026-53550 (<=4.1.1).Tag
@indentto continue the conversation here.