fix(scenarios): stop wiping a scenario's interface on every update (WM-4599)

[Uğur Oruç (Ketcap)]

[AI code generation]

Summary

• normalizePayload no longer builds a default metadata: {input_spec: [], output_spec: []}; the key is emitted only when the caller supplies blueprint.interface or blueprint.io
• Root cause: the empty arrays survived to the wire (JSON.stringify drops only undefined), and the backend's COALESCE(new_value, existing_value) only falls back on SQL NULL — so every unrelated scenarios_update (rename, folder move, scheduling tweak) silently cleared a scenario's on-demand inputs/outputs
• Clearing an interface deliberately still works: pass an explicit interface: { input: [], output: [] }
• Two existing update tests dropped their metadata: {input_spec: [], output_spec: []} expectation — that assertion encoded the bug

Fixes https://make.atlassian.net/browse/WM-4599

Test plan

• npx tsc --noEmit passes
• npx eslint passes on changed files (one pre-existing jest/expect-expect warning on an untouched test)
• npx prettier --check passes on changed files
• npx jest test/scenarios.spec.ts — 20/20 pass, including 4 new cases: no metadata on a plain rename; no metadata on a blueprint without an interface; interface hoisted into metadata when present; explicit empty interface still clears
• Full npx jest run matches the pre-change baseline exactly (193 pre-existing integration-test failures, no live API key), with +4 passing

[Copilot]

Pull request overview

Stops scenarios.update()/scenarios.create() from unintentionally clearing a scenario’s on-demand interface by no longer emitting a default empty metadata.input_spec/metadata.output_spec unless an interface source is actually provided in the blueprint.

Changes:

• Updated normalizePayload() to only include metadata when blueprint.interface or legacy blueprint.io is present.
• Added/adjusted unit tests to verify metadata is omitted for non-interface updates and that explicit empty interfaces still clear as intended.
• Minor test formatting cleanup.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/endpoints/scenarios.ts	Makes metadata emission conditional so unrelated PATCH updates don’t wipe the scenario interface.
test/scenarios.spec.ts	Updates existing expectations and adds new cases covering “no metadata unless interface is supplied” and “explicit empty interface clears”.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.