Skip to content

[JAX] Tests overhaul with custom markers for smoke tests#2480

Merged
anko-intel merged 12 commits into
mainfrom
dev/wpietkax/test-markers
Jun 12, 2026
Merged

[JAX] Tests overhaul with custom markers for smoke tests#2480
anko-intel merged 12 commits into
mainfrom
dev/wpietkax/test-markers

Conversation

@wpietka

@wpietka wpietka commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Type of Change

Feature

Description

Minor tests overhaul. Includes:

  • Adding custom marker indicating which tests are mandatory to pass before merging PR
  • Ability to mark specific combinations of test parameters as mandatory to pass before merging PR
  • Further parametrization for existing tests, increasing feature coverage
  • Small cleanups and standardization across existing tests

Expected Behavior & Potential Risk

  • Whole test suite will cover all possible use cases of neural_compressor_jax
  • CI tests will cover more uses cases than previously
  • The average execution time of tests through Github Actions doesn't increase much (about 38 minutes)
  • Increased readability and consistency of existing tests

How has this PR been tested?

Run CI tests: pytest -m smoke_test test/jax
Run all tests: pytest test/jax

Dependency Change?

No dependency changes

@wpietka
Marks specific test cases for CI
f28f8f5 
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
@wpietka wpietka mentioned this pull request May 28, 2026
Closed
wpietka added 3 commits May 29, 2026 01:19
@wpietka
Merge branch 'master' into dev/wpietkax/test-markers
9bd4019 
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
@wpietka
Decrease number of test cases
c44ec07 
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
@wpietka
Rename vit test file
745c501 
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
anko-intel
anko-intel requested changes Jun 8, 2026
View reviewed changes
Comment thread test/jax/test_gemma3.py Outdated
Comment thread test/jax/conftest.py Outdated
wpietka added 5 commits June 10, 2026 00:58
@wpietka
Improvements after review
a39d5d4 
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
@wpietka
Merge branch 'main' into dev/wpietkax/test-markers
424ce4d
@wpietka
Improve readability
b1005cb 
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
@wpietka
Adjust comment
dd245f5 
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
@wpietka
Merge branch 'dev/wpietkax/test-markers' of https://github.com/intel/…
44b872d 
…neural-compressor into dev/wpietkax/test-markers

Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
anko-intel
anko-intel reviewed Jun 10, 2026
View reviewed changes
Comment thread test/jax/conftest.py Outdated
@wpietka wpietka force-pushed the dev/wpietkax/test-markers branch from d1affe3 to 20444b4 Compare June 10, 2026 12:14
@wpietka @anko-intel
Update test/jax/conftest.py
20444b4 
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
Co-authored-by: Andrzej Kotłowski <Andrzej.Kotlowski@intel.com>
@wpietka wpietka changed the title [JAX] Tests overhaul with custom markers for CI [JAX] Tests overhaul with custom markers for smoke tests Jun 11, 2026
wpietka added 2 commits June 12, 2026 00:16
@wpietka
Use smoke_test marker in run_3x_jax.sh
5aef86a 
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
@wpietka
Rearrange arguments order
b953581 
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
@anko-intel anko-intel merged commit acb7774 into main Jun 12, 2026
14 checks passed
@anko-intel anko-intel deleted the dev/wpietkax/test-markers branch June 12, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anko-intel anko-intel anko-intel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wpietka @anko-intel