thermald: handle large RAPL PL1 values in restore registration - #593
Merged
Conversation
The RAPL restore path parsed constraint_*_power_limit_uw through the signed int reader, which fails for valid values above INT_MAX (for example 4095000000 uW). That caused restoration registration to be skipped and exit restore count to stay zero. Read PL1 as an unsigned sysfs value for registration, store it in a wider type, and restore it via string write to preserve full value range. Also update logs to print the wider PL1 type. Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RAPL restore path parsed constraint_*_power_limit_uw through the signed int reader, which fails for valid values above INT_MAX (for example 4095000000 uW). That caused restoration registration to be skipped and exit restore count to stay zero.
Read PL1 as an unsigned sysfs value for registration, store it in a wider type, and restore it via string write to preserve full value range. Also update logs to print the wider PL1 type.