fix: preserve caller-owned Apple authentication request options - #385
Open
OskarEichler wants to merge 1 commit into
Open
fix: preserve caller-owned Apple authentication request options#385OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
|
|
Collaborator
|
Hey there 👋 - just a note that I'm not going to have the fastest turn around on these but I see the whole batch, thanks a bunch for posting them up and I'll chew through them and merge everything good as fast as I get a chance Maintainer-wise I did the transition to OIDC publishing and a release to verify the automation recently enough that there should be a clear + easy path to release good fixes through here as I can qualify them Thanks for your patience |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: caller-owned request options are no longer mutated
performRequest(Object.freeze({}))currently throws before reaching native code. A normal call also adds defaults to the caller's object. Copy the options before applying the existing defaults and validation.Compatibility
No method signature or native payload change. The intentional observable change is that callers no longer receive default fields as an undocumented mutation of their options object. Frozen option objects now work.
Reproduction
24 inline cases cover defaults, explicit options, frozen inputs, validation, credential lookup and event removal. The 10 input-preservation cases fail on baseline and all pass after the fix.
Verification
5f7a8d7with the fix; no test/spec files were changed.