fix(ios): hash complete nonce bytes and batch random generation - #388
Open
OskarEichler wants to merge 1 commit into
Open
fix(ios): hash complete nonce bytes and batch random generation#388OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: complete UTF-8 nonce hashing and cheaper random generation
Compatibility / observable changes
Nonces containing NUL now hash their complete UTF-8 byte sequence, matching ordinary SHA-256 implementations. ASCII and Unicode nonces without NUL are unchanged. A random-source failure now raises the existing internal-inconsistency exception category in release builds rather than generating invalid output. The alphabet, output length, hashing algorithm and public methods are unchanged.
Reproduction and measurement
Compiled the actual Objective-C utility against Foundation/Security/CommonCrypto, with a deterministic random-source stub. Empty/ASCII/Unicode/NUL hashing has one baseline mismatch and zero fixed mismatches. Nonce lengths 0/1/16/32/128 are preserved. Random-source calls for those lengths change from 0/16/16/32/320 to 0/1/1/2/20. This is a call-count measurement, not an end-to-end authentication benchmark. Injected random failure throws with NS_BLOCK_ASSERTIONS enabled.
Verification
5f7a8d7with the fix; no test/spec files were changed.