feat: kubo 0.43.0, electron 43 - #3188
Draft
lidel wants to merge 4 commits into
Draft
Conversation
Release candidate, for smoke-testing ahead of the v0.43.0 final.
Brings Chromium 150 and V8 15.0; Node stays on 24.x. None of the Electron 43 breaking changes reach this app: both showOpenDialog call sites already pass an explicit defaultPath, showHiddenFiles is unused, toBitmap is never called, and no window sets titleBarOverlay. The splash is the only frameless window and its artwork clears the new 8 DIP corner clip on Linux, so roundedCorners keeps its default. ensure-electron.js justified its own download path by naming extract-zip, which electron's install.js no longer uses. Reword around the reason that still holds, and drop the version-specific framing so it survives the next bump.
Electron 17 removed desktopCapturer from the renderer, so the preload has seen it as undefined ever since this app moved to Electron 17 in v0.19.0, and both the tray item and the global shortcut have thrown a TypeError on every use. No webPreferences setting brings it back: sandbox:false and nodeIntegration:true each still leave it undefined. Capture where the API actually lives instead, asking for thumbnails at the display's pixel size so they are full-resolution grabs rather than previews. That drops the renderer round-trip along with getUserMedia, ImageCapture and the canvas data URL. - take-screenshot: captureScreens() over desktopCapturer and screen - webui/screenshot.js and its preload hook are gone - ipc-main-events: nothing sends SCREENSHOT any more An empty thumbnail is how a missing macOS screen-recording grant presents itself, so treat "no usable screen" as an error and raise the existing notification rather than failing silently. Closes #2306
kubo 0.43 deprecated distUrl: passing it at all takes the old dist.ipfs.tech code path and prints a deprecation notice on every build. The universal binary step was the last caller still doing that, so move it to releasesUrl, which is where the package already defaults. Matches #3180, which this branch otherwise supersedes by pinning the published kubo release rather than a git revision.
1 task
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two things users hit. The kubo binary could go missing: it arrived from a
postinstallscript, so it never landed wherever those are skipped, which npm v12 makes the default. The app then refused to start with "kubo binary not found" (#3031). Separately,Take Screenshothas thrown aTypeErroron every use since v0.19.0, when Electron 17 removeddesktopCapturerfrom the renderer and the capture code stayed there (#2306).Fix
distUrlpathgetUserMedia,ImageCaptureand the canvas hopmacOS still needs a Screen Recording grant before screenshots work. The app now raises an error there instead of failing silently, but does not request the grant yet. Supersedes #3180.