Deploy dev factory to fallback cluster#354
Merged
Merged
Conversation
TCMeldrum
approved these changes
Jun 25, 2026
ACLay
approved these changes
Jun 25, 2026
ACLay
left a comment
Contributor
There was a problem hiding this comment.
I'm fine with this going in, but I would prefer that things target clusters by label if there's no issue preventing them from being everywhere. It just means one less place needing updates as the clusters change over time, and we are expecting new proxmox hosted clusters in the near future.
Contributor
Author
|
@ACLay Makes sense, thanks. I'm going to update it. |
ACLay
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I moved the factory to gitops I excluded deploying it to the dev fallback cluster, so it only exists on the main dev cluster. Since the proposal backend is deployed to both, any factory requests from the fallback backend fail to reach the factory which is causing a lot of inconsistency.
If it's preferable to instead revert back to targeting clusters by environment label then let me know.