Skip to content

Deploy dev factory to fallback cluster#354

Merged
simonfernandes merged 2 commits into
mainfrom
deploy-dev-factory-fallback-cluster
Jun 26, 2026
Merged

Deploy dev factory to fallback cluster#354
simonfernandes merged 2 commits into
mainfrom
deploy-dev-factory-fallback-cluster

Conversation

@simonfernandes

Copy link
Copy Markdown
Contributor

When I moved the factory to gitops I excluded deploying it to the dev fallback cluster, so it only exists on the main dev cluster. Since the proposal backend is deployed to both, any factory requests from the fallback backend fail to reach the factory which is causing a lot of inconsistency.

If it's preferable to instead revert back to targeting clusters by environment label then let me know.

  generators:
  - clusters:
      selector:
        matchLabels:
          appEnvironment: dev

@simonfernandes simonfernandes requested review from a team and mutambaraf and removed request for a team June 25, 2026 12:46
@simonfernandes simonfernandes requested a review from a team June 25, 2026 12:46
@simonfernandes simonfernandes requested review from a team as code owners June 25, 2026 12:46

@ACLay ACLay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this going in, but I would prefer that things target clusters by label if there's no issue preventing them from being everywhere. It just means one less place needing updates as the clusters change over time, and we are expecting new proxmox hosted clusters in the near future.

@simonfernandes

Copy link
Copy Markdown
Contributor Author

@ACLay Makes sense, thanks. I'm going to update it.

@simonfernandes simonfernandes requested a review from ACLay June 25, 2026 15:45
@simonfernandes simonfernandes merged commit f2bbe4e into main Jun 26, 2026
@simonfernandes simonfernandes deleted the deploy-dev-factory-fallback-cluster branch June 26, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants