Draft
Conversation
Member
|
@Archmonger looks good to me. Shall we merge? |
Contributor
|
its work in progress |
Contributor
|
@VisheshBansal this PR doesn't look complete. Would be better labeled as a draft PR. |
Contributor
|
What's left to do? I'm willing to continue. |
Contributor
|
Rebased on master, added highlight on duplicate queries |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 86.31% 86.70% +0.38%
==========================================
Files 52 53 +1
Lines 2090 2166 +76
==========================================
+ Hits 1804 1878 +74
- Misses 286 288 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Will fix #398 |
albertyw
approved these changes
Oct 29, 2022
SebCorbin
approved these changes
Nov 4, 2022
Closed
SebCorbin
reviewed
Nov 10, 2022
Contributor
|
After using this PR for some time, the only feedback is UX-related, when dealing with a lot of SQL queries for a request :
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.