Skip to content

#398 Added similar queries count#439

Draft
nasirhjafri wants to merge 3 commits intomasterfrom
issues/398
Draft

#398 Added similar queries count#439
nasirhjafri wants to merge 3 commits intomasterfrom
issues/398

Conversation

@nasirhjafri
Copy link
Copy Markdown
Member

No description provided.

@nasirhjafri nasirhjafri changed the title #398 Added similar queries count [WIP] #398 Added similar queries count Aug 21, 2020
@VisheshBansal
Copy link
Copy Markdown
Member

@Archmonger looks good to me. Shall we merge?

@auvipy
Copy link
Copy Markdown
Contributor

auvipy commented Sep 10, 2021

its work in progress

@Archmonger
Copy link
Copy Markdown
Contributor

@VisheshBansal this PR doesn't look complete. Would be better labeled as a draft PR.

@Archmonger Archmonger marked this pull request as draft September 10, 2021 20:20
@SebCorbin
Copy link
Copy Markdown
Contributor

What's left to do? I'm willing to continue.
I would love to have a way of knowing which queries are duplicated at glance.

@SebCorbin
Copy link
Copy Markdown
Contributor

Rebased on master, added highlight on duplicate queries

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.70%. Comparing base (843c898) to head (cb964c3).
⚠️ Report is 164 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
+ Coverage   86.31%   86.70%   +0.38%     
==========================================
  Files          52       53       +1     
  Lines        2090     2166      +76     
==========================================
+ Hits         1804     1878      +74     
- Misses        286      288       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SebCorbin SebCorbin marked this pull request as ready for review October 24, 2022 07:33
@SebCorbin SebCorbin changed the title [WIP] #398 Added similar queries count #398 Added similar queries count Oct 24, 2022
@SebCorbin SebCorbin self-assigned this Oct 26, 2022
@SebCorbin SebCorbin requested review from a team and removed request for auvipy October 28, 2022 08:47
@SebCorbin
Copy link
Copy Markdown
Contributor

Will fix #398

@SebCorbin SebCorbin mentioned this pull request Nov 9, 2022
Comment thread silk/views/sql.py Outdated
@SebCorbin
Copy link
Copy Markdown
Contributor

After using this PR for some time, the only feedback is UX-related, when dealing with a lot of SQL queries for a request :

  • they are paginated, so the related queries may be on another page
  • the related queries are highlighted on hover, meaning two related queries may be far apart. A checkbox would be more efficient

@SebCorbin SebCorbin marked this pull request as draft January 9, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants