Implementing Custom Vision#28
Open
AlexAndrei98 wants to merge 1 commit into
Open
Conversation
Collaborator
|
For #26. Thanks for the contribution! I'll have a look at it later, I can try it too. |
miparnisari
requested changes
Nov 6, 2017
miparnisari
left a comment
miparnisari
left a comment
Collaborator
There was a problem hiding this comment.
Please add .DS_Store to .gitignore.
Please write tests for the new endpoints. I saw that you added a file but it's empty, what's the point in that?
| -A series of images to train your classifier (minimum of 30 images per tag). | ||
| -A few images to test your classifier after the classifier is trained. | ||
| * @augments commonService | ||
| * {@link https://westus.dev.cognitive.microsoft.com/docs/services/56f91f2d778daf23d8ec6739/operations/56f91f2e778daf14a499e1fa|documentation} |
Collaborator
There was a problem hiding this comment.
| * {@link https://westus.dev.cognitive.microsoft.com/docs/services/56f91f2d778daf23d8ec6739/operations/56f91f2e778daf14a499e1fa|documentation} | ||
| */ | ||
|
|
||
| class customvision extends commonService { |
Collaborator
There was a problem hiding this comment.
Please camelCase, i.e. customVisionPrediction. Also add this to index.js
| */ | ||
|
|
||
| constructor({ apiKey, endpoint }) { | ||
| super({ apiKey, endpoint }); |
Collaborator
There was a problem hiding this comment.
Add config value in config.js
| ] | ||
| } | ||
|
|
||
| predictImage({parameters, headers, body}){ |
Collaborator
There was a problem hiding this comment.
Documentation? Also, headers is not necessary (see comments below)
| "required": true, | ||
| "type": "queryStringParam", | ||
| "typeName" : "string", | ||
|
|
| "description": "Format - uuid. The project to evaluate against", | ||
| "value": null, | ||
| "required": true, | ||
| "type": "queryStringParam", |
| CreateProject({parameters, headers, body}){ | ||
|
|
||
| const operation = { | ||
| "path": "customvision/v1.0/Training/projects/{projectId}/tags?name={name}", |
Collaborator
There was a problem hiding this comment.
No need for ?name={name}
| "path": "customvision/v1.0/Training/projects/{projectId}/tags?name={name}", | ||
| "method": "POST", | ||
| "headers": [{ | ||
| "name": "TrainingKey", |
Collaborator
There was a problem hiding this comment.
Isn't this Training-key?
| "path": "customvision/v1.0/Training/projects?name={name}", | ||
| "method": "POST", | ||
| "headers": [{ | ||
| "name": "TrainingKey", |
| "required": false, | ||
| "typeName": "string" | ||
| },{ | ||
| "name": "TrainingKey", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not done implementing Custom Vision overall. Since I do not have a Azure cloud account and I cannot seem to make one I was wondering if anyone could look at test the code and give feedback.
Thanks