Skip to content

Replace command-line call to CRX2RNX by hatanaka package#231

Merged
jtec merged 2 commits into
mainfrom
hatanaka_package
Jun 3, 2026
Merged

Replace command-line call to CRX2RNX by hatanaka package#231
jtec merged 2 commits into
mainfrom
hatanaka_package

Conversation

@jtec

@jtec jtec commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Fixes #227. More robust than calling a platform-dependent binary.

Testing

Ran

--observation_file_path
/Users/janbolting/repositories/prx/debug/hatanaka/branch/TLSE00FRA_R_20230010100_10S_01S_MO.crx.gz
--log-level
debug

on main and this branch. Expanding with the hatanaka package yields a few additional observations that are dropped by CRX2RNX

$ diff ./debug/hatanaka/branch/TLSE00FRA_R_20230010100_10S_01S_MO.rnx debug/hatanaka/main/TLSE00FRA_R_20230010100_10S_01S_MO.rnx
674,682c674
< R15  24462564.781 6  24462564.207 6  24462566.441 6  24462567.301 6      2054.621 6      2054.946 6      1598.303 6      1598.312 6 130720553.663 6 130720535.665 6 101671532.525 6 101671539.511 6        39.900          39.500          36.100          36.100
< R21  24094434.109 6  24094433.766 6  24094437.484 6  24094438.410 6     -3330.949 6     -3330.766 6     -2590.591 6     -2590.612 6 128934289.769 6 128934291.767 6 100282273.207 6 100282298.204 6        40.700          40.000          37.600          36.800
< R22  20519102.570 8  20519101.355 8  20519102.906 8  20519103.574 8     -1845.656 8     -1845.439 8     -1435.350 8     -1435.343 8 109532401.929 8 109532409.927 8  85191882.180 8  85191903.183 8        52.800          51.800          49.900          49.900
< R23  20051996.086 8  20051994.688 8                                      1876.289 8      1876.437 8                                 107264586.739 8 107264897.749 8                                        51.600          49.500
< R24  23365345.313 7  23365344.680 7  23365347.332 7  23365347.875 6      3476.824 7      3476.823 7      2704.200 7      2704.204 6 124944993.105 7 124944994.118 7  97179445.010 7  97179455.011 6        44.300          43.600          42.200          41.400
< S23  38478081.469 7  38478065.273 7         4.422 7         3.301 7 202204843.258 7 150994917.598 7        44.400          42.900
< S26  40286689.984 5                       -78.730 5                 211707851.877 5                        32.300
< S36  37806292.281 7  37806275.715 7         -.133 7         -.052 7 198674589.176 7 148360075.646 7        45.600          46.000
< S48  67108863.984 6                       -32.363 6                 400806739.650 6                        39.300
---
> R15  24462564.781 6  24462564.207 6  24462566.441 6  24462567.301 6      2054.621 6      2054.946 6      1598.303 6      1598.312 6 130720553.663 6 130720535.6
\ No newline at end of file

@jtec jtec marked this pull request as ready for review June 2, 2026 15:04
@jtec jtec requested a review from plutonheaven June 2, 2026 15:04

@plutonheaven plutonheaven left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Let's add the uv.lock file and merge :)

@jtec jtec merged commit ee698ab into main Jun 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace call to CRX2RNX by https://github.com/valgur/hatanaka

2 participants