Vectorize row-wise applies#234
Merged
Merged
Conversation
PASSED [100%]2026-06-17 21:13:31,815 [DEBUG] [prx.util]: Function handle_bds_geos took 0 days 00:00:24.540819 to run. 2026-06-17 21:13:34,538 [DEBUG] [prx.util]: Function handle_bds_geos_faster took 0 days 00:00:02.708934 to run.
jtec
commented
Jun 17, 2026
|
|
||
| def test_parse_nav_file(input_for_test): | ||
| path_to_rnx3_nav_file = converters.anything_to_rinex_3(input_for_test["nav"]) | ||
| disk_cache.clear() |
Owner
Author
There was a problem hiding this comment.
This was not actually calling the parser if the nav file was cached.
jtec
commented
Jun 19, 2026
| f"Unexpected types: time is {type(time)}, timescale is {type(timescale)}" | ||
| def to_isagpst( | ||
| time: pd.Timedelta | pd.Series, | ||
| timescale: str, |
Owner
Author
There was a problem hiding this comment.
This function is actually only ever called with a timescale string, so removed the code for handling Series of timescales.
Collaborator
There was a problem hiding this comment.
We have a test_helpers.py that refers to before utils.py was renamed from helpers.py. We may want to fuse both files (test_helpers.py and test_util.py).
plutonheaven
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out about 25% of prx's run time are calls to
timedelta_2_secondswhich is called row-wise in a few places. This PR vectorizestimedelta_2_secondsand makes a few other cosmetic changes.Before
After
Note the unexpectedly large reduction in run time - did not check whether that is variability of our benchmark or additional overhead associated to calling
.applythat goes away with this change.