JEP-0013 Phase 3 - operator image

[RoddieKieley]

Summary

JEP-0013 Phase 3 PR B**: make the MetricsStream hub from PR A runnable in-cluster.

Depends on PR A: #1060

Do not merge until A is on main, then rebase this branch onto main. Related PRs C–E will be linked here as they are opened.

• Build and copy /telemetry in controller/Containerfile and make build / docker-build-ci (operator already Command: ["/telemetry"]; main still only ships manager + router).
• Expose telemetry HTTP metrics on Service/container port 8080; /healthz and /readyz probes on that port (replacing TCP probes on gRPC :9093).
• CR: spec.telemetry.metrics.scrapeTimeout, driverTypeEnum, exemplarKeys. Defaults match JEP-0013 (7s, the driver-type enum, client,lease_id). No ServiceMonitor (Phase 5).
• Set GRPC_TELEMETRY_ENDPOINT so the telemetry process advertises the in-cluster Service DNS.

TLS: #1023 already landed telemetry TLS on main. This PR keeps that path (cert-manager or manual spec.telemetry.grpc.tls.certSecret, rolling-restart hash, non-fatal missing CA). It does not reimplement TLS.

Lab: in-cluster reverse-scrape of GET /metrics on Service port 8080 worked (port-forward). After driver ops, Python OpenMetrics exemplars still fail Go parseMetricFamilies; the hub from A omits that snapshot and increments jumpstarter_metrics_parse_errors_total. spec.telemetry.metrics.exemplarKeys only allowlists keys on the merge path after a successful parse — it does not fix exemplar decode. That remains A / JEP DD-3, not this PR.

DEMO

The lab walkthrough for the stacked Phase 3 work (A+B+C+D+E plus lab-only Route) is on the fork demo branch, not this PR:

• DEMO.md
• jep-0013-phase3-demo.cast

See MetricsStream during the lease for the DD-3 exemplar limitation observed on :8080.

How this PR fits the series

flowchart TB
  A["PR A #1060: proto + hub"]
  B["PR B this PR: image + metrics port + scrape CR"]
  C["PR C: exporter MetricsStream client"]
  D["PR D: Loki HTTP push"]
  E["PR E: jmp PushLogs"]
  A --> B
  A --> C
  B --> D
  D --> E

Loading

PR	Branch	Status
A	jep-0013-phase3-metricsstream	#1060
B	jep-0013-phase3-operator-image	This PR
C	jep-0013-phase3-exporter-metricsstream	#1062
D	jep-0013-phase3-loki-push	#1063
E	jep-0013-phase3-client-pushlogs	#1064

Unique work vs PR A: the operator/image commit on this branch (435eebee). If GitHub shows A's commits, that is stacking against main; review that unique commit only.

Out of scope

• MetricsStream protocol and parse-error omit (A / JEP-0013 Phase 3 - MetricsStream #1060)
• Exporter MetricsStream client and Register identity (C) — after #1058, identity must be exporter_name, not Metadata.name
• Loki / PushLogs (D, E), including exporter TFTP errors that only show up on the log path
• Advertising a Route/hostname for out-of-cluster exporters (lab-only on the demo branch)
• ServiceMonitor (Phase 5)

NOTE

Open #1027 also touches telemetry operator files (log-ingest e2e).

[coderabbitai]

Warning

Review limit reached

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: e8a9202e-3561-4b2c-9e70-c2cd15edac03

📥 Commits

Reviewing files that changed from the base of the PR and between f1b7f24 and 435eebe.

⛔ Files ignored due to path filters (2)

• controller/internal/protocol/jumpstarter/v1/telemetry.pb.go is excluded by !**/*.pb.go
• controller/internal/protocol/jumpstarter/v1/telemetry_grpc.pb.go is excluded by !**/*.pb.go

📒 Files selected for processing (23)

• controller/Containerfile
• controller/Makefile
• controller/cmd/telemetry/main.go
• controller/deploy/operator/api/v1alpha1/jumpstarter_types.go
• controller/deploy/operator/api/v1alpha1/zz_generated.deepcopy.go
• controller/deploy/operator/config/crd/bases/operator.jumpstarter.dev_jumpstarters.yaml
• controller/deploy/operator/internal/controller/jumpstarter/jumpstarter_controller.go
• controller/deploy/operator/internal/controller/jumpstarter/telemetry.go
• controller/deploy/operator/internal/controller/jumpstarter/telemetry_phase3_test.go
• controller/deploy/operator/internal/controller/jumpstarter/telemetry_test.go
• controller/image_layout_test.go
• controller/internal/service/metrics_merge.go
• controller/internal/service/metrics_merge_test.go
• controller/internal/service/metrics_stream.go
• controller/internal/service/metrics_stream_test.go
• controller/internal/service/telemetry_http.go
• controller/internal/service/telemetry_identity.go
• controller/internal/service/telemetry_service.go
• protocol/proto/jumpstarter/v1/telemetry.proto
• python/packages/jumpstarter-protocol/jumpstarter_protocol/jumpstarter/v1/telemetry_pb2.py
• python/packages/jumpstarter-protocol/jumpstarter_protocol/jumpstarter/v1/telemetry_pb2.pyi
• python/packages/jumpstarter-protocol/jumpstarter_protocol/jumpstarter/v1/telemetry_pb2_grpc.py
• python/packages/jumpstarter-protocol/jumpstarter_protocol/jumpstarter/v1/telemetry_pb2_grpc.pyi

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}