chore: optimize ImageRandomizer#100
Merged
Merged
Conversation
I ran a profiler against help.keyman.com pages and found that the ImageRandomizer was surprisingly slow, due to its `glob` call. I opted to hard code the image filenames and use `random_int` to select an image as a more efficient alternative. If we change the logo images, we'll need to update the list of filenames here. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran a profiler against help.keyman.com pages and found that the ImageRandomizer was surprisingly slow, due to its
globcall. I opted to hard code the image filenames and userandom_intto select an image as a more efficient alternative.If we change the logo images, we'll need to update the list of filenames here.
Test-bot: skip