fix(overflow-items,actions-panel): flaky visibility recalculations (#DS-5130) by artembelik · Pull Request #1634 · koobiq/angular-components

artembelik · 2026-06-15T12:48:49Z

No description provided.

github-actions · 2026-06-15T12:53:24Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

github-actions · 2026-06-15T12:53:42Z

Visit the preview URL for this PR (updated for commit fb62aed):

https://koobiq-next--prs-1634-rxcuo2dj.web.app

_{(expires Sun, 28 Jun 2026 10:32:29 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c}

Copilot

Pull request overview

This PR addresses flaky overflow/visibility recalculations in KbqOverflowItems (and a related KbqActionsPanel overlay-container sizing case) by changing how available space is measured and by expanding unit/e2e coverage for resize-driven recalculation scenarios.

Changes:

Switched overflow measurement to getBoundingClientRect() and captured available container size once per recalculation to avoid circular shrink/hide feedback loops.
Added/expanded unit tests and Playwright e2e scenarios covering orientation changes, debounce behavior, dynamic items, left-margin sizing, and additional resize-observer targets.
Refactored KbqActionsPanel overlay max-width syncing into a helper and added resize-related e2e/spec coverage.

Reviewed changes

Copilot reviewed 7 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
packages/components/overflow-items/overflow-items.ts	Updates sizing logic and stabilizes the hide-loop by snapshotting available size.
packages/components/overflow-items/overflow-items.spec.ts	Adds unit coverage for resize-observer targets, debounce, orientation changes, and visibility manager behavior.
packages/components/overflow-items/e2e.ts	Adds new e2e demo scenarios (margin-left, debounce, additional targets, dynamic add/remove).
packages/components/overflow-items/e2e.playwright-spec.ts	Adds Playwright coverage for live resize, debounce, additional targets, margins, vertical alwaysVisible edge cases, and dynamic items.
packages/components/actions-panel/actions-panel.ts	Extracts max-width syncing and applies it before subscribing to resize updates.
packages/components/actions-panel/actions-panel.spec.ts	Adds tests for array class inputs, default config provider, open-twice behavior, and overlayContainer maxWidth syncing.
packages/components/actions-panel/e2e.playwright-spec.ts	Adds dark-theme screenshot coverage and a new container-resize overflow behavior test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

artembelik · 2026-06-15T13:00:45Z

/approve-snapshots

github-actions · 2026-06-15T13:01:00Z

🔄 Updating snapshots.

github-actions · 2026-06-15T13:04:56Z

🚨 Failed to update snapshots.

github-actions · 2026-06-15T13:12:16Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

github-actions · 2026-06-15T13:43:30Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

github-actions · 2026-06-15T13:52:54Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

github-actions · 2026-06-15T14:25:55Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

github-actions · 2026-06-22T11:09:10Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

artembelik · 2026-06-22T11:58:30Z

/approve-snapshots

github-actions · 2026-06-22T11:58:46Z

🔄 Updating snapshots.

github-actions · 2026-06-22T12:03:06Z

🚨 Failed to update snapshots.

github-actions · 2026-06-22T12:27:34Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

artembelik · 2026-06-22T12:31:06Z

/approve-snapshots

github-actions · 2026-06-22T12:31:19Z

🔄 Updating snapshots.

github-actions · 2026-06-22T12:35:24Z

🚨 Failed to update snapshots.

github-actions · 2026-06-22T12:45:51Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

artembelik · 2026-06-22T12:47:16Z

/approve-snapshots

github-actions · 2026-06-22T12:47:32Z

🔄 Updating snapshots.

github-actions · 2026-06-22T12:52:16Z

✅ Snapshots updated!

Copilot

Pull request overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.

…DS-5130)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

artembelik self-assigned this Jun 15, 2026

Copilot AI review requested due to automatic review settings June 15, 2026 12:48

artembelik requested a review from lskramarov as a code owner June 15, 2026 12:48

artembelik added the bug Something isn't working label Jun 15, 2026

Copilot started reviewing on behalf of artembelik June 15, 2026 12:49 View session

Copilot AI reviewed Jun 15, 2026

View reviewed changes

artembelik force-pushed the fix/DS-5130 branch from 62b0b64 to ad28e0b Compare June 15, 2026 14:20

artembelik requested a review from NikGurev as a code owner June 15, 2026 14:20

artembelik marked this pull request as draft June 22, 2026 07:49

artembelik marked this pull request as ready for review June 22, 2026 13:17

artembelik requested a review from Copilot June 22, 2026 13:20

Copilot started reviewing on behalf of artembelik June 22, 2026 13:21 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

Comment thread packages/components/breadcrumbs/e2e.playwright-spec.ts Outdated

Comment thread packages/components/actions-panel/actions-panel.ts

Comment thread packages/components/actions-panel/actions-panel.ts

artembelik and others added 11 commits June 22, 2026 16:37

fix(overflow-items,actions-panel): flaky visibility recalculations (#…

c16dff5

…DS-5130)

Potential fix for pull request finding

cfe7c57

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

refactor: tests

6e1fe52

refactor: tests

ea8e30a

refactor: breadcrumbs e2e

ede55d4

refactor: overflow items

c44de10

refactor: e2e

aae3223

refactor: e2e

1cf34ad

test: updated e2e snapshots

2b4e083

refactor: e2e

414ef76

refactor: e2e

3840eb7

artembelik force-pushed the fix/DS-5130 branch from 4f26d83 to 3840eb7 Compare June 22, 2026 13:37

Potential fix for pull request finding

17389ee

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

NikGurev reviewed Jun 22, 2026

View reviewed changes

Comment thread packages/components/top-bar/__screenshots__/01-dark.png

NikGurev approved these changes Jun 22, 2026

View reviewed changes

lskramarov approved these changes Jun 23, 2026

View reviewed changes

Comment thread packages/components/actions-panel/actions-panel.spec.ts

refactor: units

fb62aed

artembelik merged commit 49d6ff9 into main Jun 23, 2026
8 checks passed

artembelik deleted the fix/DS-5130 branch June 23, 2026 11:44

Conversation

artembelik commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026

🚨 E2E tests failed

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

artembelik commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026

🚨 E2E tests failed

Uh oh!

github-actions Bot commented Jun 15, 2026

🚨 E2E tests failed

Uh oh!

github-actions Bot commented Jun 15, 2026

🚨 E2E tests failed

Uh oh!

github-actions Bot commented Jun 15, 2026

🚨 E2E tests failed

Uh oh!

github-actions Bot commented Jun 22, 2026

🚨 E2E tests failed

Uh oh!

artembelik commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

🚨 E2E tests failed

Uh oh!

artembelik commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

🚨 E2E tests failed

Uh oh!

artembelik commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

github-actions Bot commented Jun 15, 2026 •

edited

Loading