Skip to content

feat(title): support custom content and multiple text elements (#DS-3672)#1645

Merged
lskramarov merged 2 commits into
mainfrom
feat/DS-3672
Jun 23, 2026
Merged

feat(title): support custom content and multiple text elements (#DS-3672)#1645
lskramarov merged 2 commits into
mainfrom
feat/DS-3672

Conversation

@lskramarov

Copy link
Copy Markdown
Contributor

No description provided.

@lskramarov lskramarov self-assigned this Jun 18, 2026
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 90cc177):

https://koobiq-next--prs-1645-hunzz3lp.web.app

(expires Sun, 28 Jun 2026 10:58:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the kbq-title directive to support custom tooltip content (string or TemplateRef) and overflow detection across multiple text elements, and then migrates filter-bar pipes from the removed KbqPipeTitleDirective to the unified kbq-title API. It also updates the public API snapshots, documentation, and docs examples to reflect the new capabilities and usage patterns.

Changes:

  • Extend KbqTitleDirective to accept [kbq-title] custom content and detect overflow for multiple #kbqTitleText elements.
  • Remove KbqPipeTitleDirective and migrate filter-bar pipes to use [kbq-title].
  • Add/update documentation and docs examples (including multiline/vertical overflow and multi-text scenarios) and update API guard snapshots.

Reviewed changes

Copilot reviewed 44 out of 44 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/public_api_guard/components/tooltip.api.md Updates API snapshot to reflect documented KbqTooltipTrigger surface.
tools/public_api_guard/components/title.api.md Updates API snapshot for KbqTitleDirective to include the new titleContent signal input.
tools/public_api_guard/components/filter-bar.api.md Removes KbqPipeTitleDirective from the filter-bar public API snapshot.
tools/public_api_guard/components/core.api.md Marks KbqPopUpTrigger as documented in the API snapshot.
tools/cspell-locales/ru.json Adds RU dictionary words used by new/updated docs.
packages/docs-examples/example-module.ts Registers new title examples and wires lazy-loading cases.
packages/docs-examples/components/title/title-vertical-overflow/title-vertical-overflow-example.ts New example demonstrating vertical (multiline) overflow behavior.
packages/docs-examples/components/title/title-vertical-overflow/title-vertical-overflow-example.css Styles for multiline clamp overflow example.
packages/docs-examples/components/title/title-overview/title-overview-example.ts Simplifies the overview example to focus on the main scenario.
packages/docs-examples/components/title/title-overview/title-overview-example.css Removes leftover dev-only styling from the overview example.
packages/docs-examples/components/title/title-multiple-text/title-multiple-text-example.ts New example demonstrating multiple text elements overflow detection.
packages/docs-examples/components/title/title-multiple-text/title-multiple-text-example.css Styles for multi-text overflow example.
packages/docs-examples/components/title/title-list-option/title-list-option-example.ts New example demonstrating two-line list option overflow handling.
packages/docs-examples/components/title/title-list-option/title-list-option-example.css Ensures flex column can shrink so truncation/overflow is detectable.
packages/docs-examples/components/title/title-custom-content/title-custom-content-example.ts New example demonstrating custom tooltip content (string + template).
packages/docs-examples/components/title/title-custom-content/title-custom-content-example.css Styles for custom-content example.
packages/docs-examples/components/title/index.ts Exports and declares the new title examples.
packages/docs-examples/components/filter-bar/filter-bar-custom-pipe/filter-bar-custom-pipe-example.ts Migrates example usage from [kbqPipeTitle] to [kbq-title].
packages/components/tooltip/tooltip.component.ts Adds documentation and small refactors/annotations for tooltip trigger inputs/outputs.
packages/components/title/title.ru.md Adds RU documentation describing new kbq-title capabilities and examples.
packages/components/title/title.en.md Adds EN documentation describing new kbq-title capabilities and examples.
packages/components/title/title.directive.ts Implements custom content input + multi-text overflow detection and updated parent/child resolution.
packages/components/title/title.directive.spec.ts Adds test coverage for explicit content input and multiple #kbqTitleText children.
packages/components/filter-bar/public-api.ts Stops exporting the removed pipe-title symbol(s).
packages/components/filter-bar/pipes/pipe-tree-select.ts Removes dependency on KbqPipeTitleDirective.
packages/components/filter-bar/pipes/pipe-tree-select.html Migrates [kbqPipeTitle] to [kbq-title].
packages/components/filter-bar/pipes/pipe-title.ts Deletes the old KbqPipeTitleDirective.
packages/components/filter-bar/pipes/pipe-text.ts Removes dependency on KbqPipeTitleDirective.
packages/components/filter-bar/pipes/pipe-text.html Migrates [kbqPipeTitle] to [kbq-title].
packages/components/filter-bar/pipes/pipe-select.ts Removes dependency on KbqPipeTitleDirective.
packages/components/filter-bar/pipes/pipe-select.html Migrates [kbqPipeTitle] to [kbq-title].
packages/components/filter-bar/pipes/pipe-readonly.ts Migrates inline template usage to [kbq-title].
packages/components/filter-bar/pipes/pipe-multi-tree-select.ts Removes dependency on KbqPipeTitleDirective.
packages/components/filter-bar/pipes/pipe-multi-tree-select.html Migrates [kbqPipeTitle] to [kbq-title].
packages/components/filter-bar/pipes/pipe-multi-select.ts Removes dependency on KbqPipeTitleDirective.
packages/components/filter-bar/pipes/pipe-multi-select.html Migrates [kbqPipeTitle] to [kbq-title].
packages/components/filter-bar/pipes/pipe-datetime.ts Removes dependency on KbqPipeTitleDirective.
packages/components/filter-bar/pipes/pipe-datetime.html Migrates [kbqPipeTitle] to [kbq-title].
packages/components/filter-bar/pipes/pipe-date.ts Removes dependency on KbqPipeTitleDirective.
packages/components/filter-bar/pipes/pipe-date.html Migrates [kbqPipeTitle] to [kbq-title].
packages/components/filter-bar/filter-bar.module.ts Removes KbqPipeTitleDirective from module declarations.
packages/components/core/pop-up/pop-up-trigger.ts Adds/updates documentation for KbqPopUpTrigger internals.
packages/components-dev/title/template.html Removes outdated dev demo block superseded by new examples/docs.
packages/components-dev/title/styles.scss Removes leftover dev-only styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/components/title/title.directive.ts
Comment thread packages/components/title/title.directive.ts
Comment thread packages/components/filter-bar/public-api.ts
@rmnturov

Copy link
Copy Markdown
Contributor

В примере «Собственное содержимое подсказки» иконку надо сделать --kbq-icon-white чтобы не было эффекта «черное на черном»
image

@lskramarov lskramarov merged commit 10d79fe into main Jun 23, 2026
8 checks passed
@lskramarov lskramarov deleted the feat/DS-3672 branch June 23, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants