Skip to content

fix(dropdown): correct offsetY for explicit yPosition='above' (#DS-5168)#1648

Merged
NikGurev merged 2 commits into
mainfrom
bugfix/DS-5168
Jun 23, 2026
Merged

fix(dropdown): correct offsetY for explicit yPosition='above' (#DS-5168)#1648
NikGurev merged 2 commits into
mainfrom
bugfix/DS-5168

Conversation

@NikGurev

Copy link
Copy Markdown
Contributor

No description provided.

@NikGurev NikGurev requested a review from lskramarov June 23, 2026 07:31
@NikGurev NikGurev self-assigned this Jun 23, 2026
@NikGurev NikGurev requested a review from artembelik as a code owner June 23, 2026 07:31
@NikGurev NikGurev added the bug Something isn't working label Jun 23, 2026
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit ebb7bf1):

https://koobiq-next--prs-1648-ot37ywsx.web.app

(expires Sun, 28 Jun 2026 10:12:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes dropdown vertical offset behavior when yPosition="above" is explicitly set, ensuring the overlay gap is applied in the correct direction and adding regression tests to cover the corrected positioning.

Changes:

  • Adjusted KbqDropdownTrigger position strategy to resolve offsetY sign based on the effective overlayY connection point.
  • Added unit tests verifying (1) explicit yPosition="above" opens above when space allows, and (2) the generated CDK positions carry the expected offsetY direction for both above and below.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/components/dropdown/dropdown-trigger.directive.ts Fixes vertical offset sign resolution so explicit yPosition="above" applies a negative offsetY for the “panel above” positions.
packages/components/dropdown/dropdown.spec.ts Adds regression coverage for explicit above positioning and verifies offsetY direction passed into withPositions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/components/dropdown/dropdown.spec.ts Outdated
Comment thread packages/components/dropdown/dropdown.spec.ts Outdated
@NikGurev NikGurev merged commit 235b907 into main Jun 23, 2026
8 checks passed
@NikGurev NikGurev deleted the bugfix/DS-5168 branch June 23, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants