fix(dropdown): correct offsetY for explicit yPosition='above' (#DS-5168)#1648
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit ebb7bf1): https://koobiq-next--prs-1648-ot37ywsx.web.app (expires Sun, 28 Jun 2026 10:12:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes dropdown vertical offset behavior when yPosition="above" is explicitly set, ensuring the overlay gap is applied in the correct direction and adding regression tests to cover the corrected positioning.
Changes:
- Adjusted
KbqDropdownTriggerposition strategy to resolveoffsetYsign based on the effectiveoverlayYconnection point. - Added unit tests verifying (1) explicit
yPosition="above"opens above when space allows, and (2) the generated CDK positions carry the expectedoffsetYdirection for bothaboveandbelow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/components/dropdown/dropdown-trigger.directive.ts |
Fixes vertical offset sign resolution so explicit yPosition="above" applies a negative offsetY for the “panel above” positions. |
packages/components/dropdown/dropdown.spec.ts |
Adds regression coverage for explicit above positioning and verifies offsetY direction passed into withPositions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
artembelik
approved these changes
Jun 23, 2026
lskramarov
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.