This repository was archived by the owner on Aug 5, 2026. It is now read-only.
fix(composition): adopt un-owned child on umbrella upgrade (D1 upgrade-layer) - #15
Merged
Merged
Conversation
…e child cannot wedge the whole release (D1 upgrade-layer) Complements chart-inspector#4 (render layer). The cdc's hc.Upgrade also aborts with 'cannot be imported into the current release: invalid ownership metadata' when a child composition instance exists with non-Helm ownership (created/edited out-of-band), wedging the whole platform reconcile. Set TakeOwnership on both upgrade paths so helm adopts the child and self-heals its ownership. Requires braghettos/plumbing v1.7.8, which maps TakeOwnership in applyUpgradeConfig (was install-only); replace bumped v1.7.7->v1.7.8. Validated: go build ./... passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FzZJtQ4bEMHuK4CvF6eBuL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes D1 (paired with chart-inspector#4, the render layer). The cdc's actual
hc.Upgradeof a composition also aborts withcannot be imported into the current release: invalid ownership metadatawhen a child instance exists with non-Helm ownership (out-of-band created/edited), wedging the whole reconcile.Fix:
TakeOwnership: trueon both upgrade paths → helm adopts the child and self-heals its ownership instead of failing.Dependency: helm
action.UpgradesupportsTakeOwnership, but plumbingapplyUpgradeConfigonly wired it for install. Fixed in braghettos/plumbing v1.7.8 (v1.7.7 + one line); thereplacedirective is bumpedv1.7.7 -> v1.7.8and go.sum updated.Validation:
go mod tidy+go build ./...pass locally with v1.7.8.🤖 Generated with Claude Code