fix: make Supporters CTA host-safe - #856
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request cleans up trailing spaces in the supporters list and updates the community supporters link to use a relative path instead of an absolute URL, while also adding rel="noopener noreferrer" for security. The reviewer suggests using Docusaurus's built-in <Link> component instead of a raw <a> tag to automatically handle locale prefixes, base URLs, and security attributes, which would also allow removing the unused i18n context.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
Which issue(s) this PR fixes:
Fixes #854.
Bug fix.
The homepage Supporters header CTA hardcodes
https://kubeedge.io/${i18n.currentLocale}/docs/community/supportersand opens a new tab withoutrel="noopener noreferrer".The CTA now points to a current-host-safe locale path and adds
rel="noopener noreferrer"while preserving the existing new-tab behavior.No.
npx -y yarn@1.22.22 install --frozen-lockfile.npx -y -p node@20 --call "node ./node_modules/@docusaurus/core/bin/docusaurus.mjs build".npx -y prettier@3.3.3 --check src/components/supporters/index.js.Before the fix:
After the fix: