Skip to content

fix: make Supporters CTA host-safe - #856

Open
RedZapdos123 wants to merge 2 commits into
kubeedge:masterfrom
RedZapdos123:fix/supporters-header-cta-host-safe-link
Open

fix: make Supporters CTA host-safe#856
RedZapdos123 wants to merge 2 commits into
kubeedge:masterfrom
RedZapdos123:fix/supporters-header-cta-host-safe-link

Conversation

@RedZapdos123

@RedZapdos123 RedZapdos123 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

Which issue(s) this PR fixes:
Fixes #854.

  • What kind of change does this PR introduce?

Bug fix.

  • What is the current behavior?

The homepage Supporters header CTA hardcodes https://kubeedge.io/${i18n.currentLocale}/docs/community/supporters and opens a new tab without rel="noopener noreferrer".

  • What is the new behavior ?

The CTA now points to a current-host-safe locale path and adds rel="noopener noreferrer" while preserving the existing new-tab behavior.

  • Does this PR introduce a breaking change?

No.

  • Other information:
  • Verified with npx -y yarn@1.22.22 install --frozen-lockfile.
  • Verified with npx -y -p node@20 --call "node ./node_modules/@docusaurus/core/bin/docusaurus.mjs build".
  • Verified with npx -y prettier@3.3.3 --check src/components/supporters/index.js.
  • Proof was checked from the generated built homepage Supporters CTA before and after the fix.

Before the fix:

image

After the fix:

image

Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zhiyingfang2022 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zhiyingfang2022 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up trailing spaces in the supporters list and updates the community supporters link to use a relative path instead of an absolute URL, while also adding rel="noopener noreferrer" for security. The reviewer suggests using Docusaurus's built-in <Link> component instead of a raw <a> tag to automatically handle locale prefixes, base URLs, and security attributes, which would also allow removing the unused i18n context.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/components/supporters/index.js Outdated
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Supporters header CTA hardcodes production URL and uses target="_blank" without rel protection

2 participants