docs: update stale KubeEdge version references in keadm/keink setup guides - #866
Open
Priyanshubhartistm wants to merge 1 commit into
Open
Conversation
…uides Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
Docs fix.
docs/setup/install-with-keadm.mdmixes two different KubeEdge versions in the same document: the cloud-side install examples (wget/docker run/keadm init) usev1.17.0, while the edge-sidekeadm joinexamples usev1.12.1/1.12.0. Both are well behind the current release (v1.23.1), and having two different versions in one walkthrough is confusing for anyone copy-pasting the commands.docs/setup/install-with-keink.mdhas a similar problem, but worse line 33 claims "Deploy the latest recommended version of KubeEdge v1.17", which is just false at this point and will go stale again the next time a release ships.Same issues exist in the Chinese translations of both files.
install-with-keadm.mdnow usesv1.23.1consistently across every example command (download, docker run,keadm init,keadm join,keadm deprecated join), in both English and Chinese.install-with-keink.mdno longer hardcodes a version number in prose it now links to the GitHub releases page instead, so the line doesn't need to be manually bumped on every release going forward. Same change applied to the Chinese translation.Verified all four pages with
yarn start(English and Chinese locales) and confirmed the rendered output shows the corrected versions/link.codespell --config codespell.cfgandyarn buildboth pass.No.
Scoped this narrowly to the version strings themselves, not a rewrite of either guide a few earlier PRs (#721, #725, #730-733) attempted broader
install-with-keadm.mdupdates for older releases and stalled/got auto-closed, so keeping this mechanical.