docs(slides): document table dimensions#1920
Conversation
📝 WalkthroughWalkthroughThe Slides XML schema now exposes optional table width and height attributes and documents deterministic allocation for columns and rows. The XML format guide adds matching rules and an example covering explicit sizes, remaining space, insufficient dimensions, and content-driven row height requirements. ChangesTable sizing behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-slides/references/xml-format-guide.md`:
- Around line 266-269: Update the allocation rules section in the XML format
guide to include redistribution of extra space by current-size weights when all
dimensions are explicitly set, and specify that unset columns and rows use
defaults of 110 and 37 respectively when remaining space is insufficient.
Preserve the existing rules while documenting that the final total is determined
after these fallbacks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ee6fab80-306d-4b69-bc94-93f6ca4a5aea
📒 Files selected for processing (2)
skills/lark-slides/references/slides_xml_schema_definition.xmlskills/lark-slides/references/xml-format-guide.md
| - 已设置的列宽和行高优先保留;未设置的列宽、行高优先使用目标总宽度或总高度分配剩余空间。 | ||
| - 如果所有列宽或行高都未设置,则目标总宽度或总高度会在各列或各行之间分配。 | ||
| - 如果目标尺寸不足以容纳已设置的尺寸,则保留已设置值,并以最终列宽或行高总和为准。 | ||
| - 行高低于单元格内容高度时,需要手动增大行高。 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Mirror the schema’s complete allocation contract here.
These bullets omit two important rules: extra space is redistributed by current-size weights when every dimension is explicit, and insufficient remaining space causes unset entries to fall back to defaults (110 for columns, 37 for rows) before the final total is determined. Without those details, guide users may implement behavior that differs from the schema.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/lark-slides/references/xml-format-guide.md` around lines 266 - 269,
Update the allocation rules section in the XML format guide to include
redistribution of extra space by current-size weights when all dimensions are
explicitly set, and specify that unset columns and rows use defaults of 110 and
37 respectively when remaining space is insufficient. Preserve the existing
rules while documenting that the final total is determined after these
fallbacks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1920 +/- ##
=======================================
Coverage 74.96% 74.96%
=======================================
Files 892 892
Lines 94058 94058
=======================================
Hits 70506 70506
Misses 18139 18139
Partials 5413 5413 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@dae3e5501db7238a6bf59efd278f8f781257d30d🧩 Skill updatenpx skills add larksuite/cli#docs/slide-table-dimensions -y -g |
| </table> | ||
| ``` | ||
|
|
||
| - 已设置的列宽和行高优先保留;未设置的列宽、行高优先使用目标总宽度或总高度分配剩余空间。 |
Summary
Documents table sizing dimensions in the Slides XML schema reference and XML format guide.
Changes
Test Plan
Related Issues
Summary by CodeRabbit
New Features
Documentation