Skip to content

[19.0][FIX] attachment_preview: extend AttachmentButtons, not the removed aside #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnplkndll wants to merge 1 commit into
base: 19.0-mig-attachment_preview
Choose a base branch
from
Open

[19.0][FIX] attachment_preview: extend AttachmentButtons, not the removed aside #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion attachment_preview/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"name": "Preview attachments",
"version": "19.0.1.0.0",
"author": "Therp BV,Onestein,Odoo Community Association (OCA)",
"author": "Therp BV, Onestein, Odoo Community Association (OCA)",
"website": "https://github.com/OCA/knowledge",
"license": "AGPL-3",
"summary": "Preview attachments supported by Viewer.js",
Expand Down
71 changes: 38 additions & 33 deletions attachment_preview/static/src/xml/attachment_preview.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,45 @@
<?xml version="1.0" encoding="UTF-8" ?>
<templates>
<!--
Odoo 19 restructured mail.AttachmentList. The o-mail-AttachmentCard-aside
element this template used to extend no longer exists, so the xpath could
not resolve and the whole chatter failed to render on any record carrying
an attachment. Server-side tests do not render the OWL template, which is
why CI stayed green.

The per-attachment actions now live in the o-mail-AttachmentButtons hover
group next to Download and Remove, so add the preview buttons there and
match the styling of their siblings.
-->
<t t-name="Attachment" t-inherit="mail.AttachmentList" t-inherit-mode="extension">
<xpath expr="//div[hasclass('o-mail-AttachmentCard-aside')]" position="before">
<div
t-if="attachment.downloadUrl"
class="o-mail-AttachmentCard-aside position-relative rounded-end overflow-hidden d-flex"
t-att-class="{ 'o-hasMultipleActions d-flex flex-column': showDelete and !env.inComposer }"
<xpath expr="//div[hasclass('o-mail-AttachmentButtons')]" position="inside">
<button
t-if="this._canPreviewAttachment(attachment)"
class="btn bg-500 w-100 h-100 o-p-1_5 d-flex justify-content-center align-items-center shadow-sm"
t-att-data-id="attachment.id"
t-att-data-url="attachment.defaultSource"
t-on-click.stop="() => this._onPreviewAttachment(attachment)"
t-att-data-original-title="attachment.name"
t-attf-title="Preview {{attachment.name}} in side panel"
>
<button
t-if="this._canPreviewAttachment(attachment)"
class="d-flex justify-content-center align-items-center w-100 h-100 border-0 bg-300"
t-att-data-id="attachment.id"
t-att-data-url="attachment.defaultSource"
t-on-click.stop="() => this._onPreviewAttachment(attachment)"
t-att-data-original-title="attachment.name"
t-attf-title="Preview {{attachment.displayName}} in side panel"
>
<i class="fa fa-search" role="img" aria-label="Preview" />
</button>
<button
t-if="this._canPreviewAttachment(attachment)"
class="d-flex justify-content-center align-items-center w-100 h-100 border-0 bg-300"
data-target="new"
t-att-data-id="attachment.id"
t-att-data-url="attachment.defaultSource"
t-on-click.stop="() => this._onPreviewAttachment(attachment)"
t-att-data-original-title="attachment.name"
t-attf-title="Open preview {{attachment.name}} in a new tab"
>
<i
class="fa fa-external-link"
role="img"
aria-label="Open in new page"
/>
</button>
</div>
<i class="fa fa-search o-text-white" role="img" aria-label="Preview" />
</button>
<button
t-if="this._canPreviewAttachment(attachment)"
class="btn bg-500 w-100 h-100 o-p-1_5 d-flex justify-content-center align-items-center shadow-sm"
data-target="new"
t-att-data-id="attachment.id"
t-att-data-url="attachment.defaultSource"
t-on-click.stop="() => this._onPreviewAttachment(attachment)"
t-att-data-original-title="attachment.name"
t-attf-title="Open preview {{attachment.name}} in a new tab"
>
<i
class="fa fa-external-link o-text-white"
role="img"
aria-label="Open in new page"
/>
</button>
</xpath>
</t>

Expand Down
Loading