[fork-CI] [19.0][MIG] web_send_message_popup: Migration to 19.0 - #7
Draft
dnplkndll wants to merge 27 commits into
Draft
[fork-CI] [19.0][MIG] web_send_message_popup: Migration to 19.0#7dnplkndll wants to merge 27 commits into
dnplkndll wants to merge 27 commits into
Conversation
dnplkndll
force-pushed
the
19.0-mig-web_send_message_popup
branch
7 times, most recently
from
June 13, 2026 17:21
414efab to
db27a98
Compare
…to open directly the full featured message popup
* Intitial manifest changes * [FIX] small README tricks
Currently translated at 100.0% (1 of 1 strings) Translation: web-16.0/web-16.0-web_send_message_popup Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_send_message_popup/it/
Currently translated at 100.0% (2 of 2 strings) Translation: web-18.0/web-18.0-web_send_message_popup Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_send_message_popup/sl/
dnplkndll
force-pushed
the
19.0-mig-web_send_message_popup
branch
4 times, most recently
from
June 13, 2026 18:44
286ae0f to
51e1d67
Compare
Assisted-by: Claude Opus 5
dnplkndll
force-pushed
the
19.0-mig-web_send_message_popup
branch
from
August 22, 2026 00:37
51e1d67 to
defae2b
Compare
Core reimplements Chatter.toggleComposer in mail/chatter/web/chatter_patch.js without calling super, so the last patch applied wins outright. Importing that file for its side effect is what puts this module's override outermost; without it the patch is silently inert and "Send message" opens the inline composer. Realigned with 19.0 core: - toggleComposer: the "message" branch now awaits updateRecipients (new in 19.0; refreshes suggestedRecipients from unsaved partner/email form edits) before opening the wizard, and defers through onThreadCreated when the record is unsaved instead of opening against a thread without an id, mirroring core's toggle structure. - context: added clicked_on_full_composer (the wizard otherwise hides the followers-only recipients widget and makes the forward-style one required), is_thread_composer and body_contains_signature_only; dropped mail_post_autofollow, which core removed deliberately in 18.2+. - default_partner_ids: restored core's filter on partner_id. - onCloseFullComposerCallback now receives isDiscard. It gained the argument in 19.0, and reloadParentView() starts with saveRecord(), so discarding a message was silently saving the underlying form record. - formatDefaultBodyForFullComposer: createDocumentFragmentFromContent, the BR before the signature, and markup() on return, per core's composer_patch. - onClose clears replyToMessage, as core does, so a reply context does not leak into the next inline composer. - notifySendFromMailbox delegates to the store method core exposes rather than duplicating it and its translatable string. ROADMAP records that Composer.fullComposerAdditionalContext is not consulted: the action is built from the chatter, not a rendered composer. Assisted-by: Claude Opus 5 Assisted-by: Claude Fable 5
Drives the "Send message" button rather than calling openFullComposer() directly, so the patched toggleComposer is actually exercised. The previous shape reached the module by a path no user takes and passed while the module was inert. Also gates the two paths that had no coverage: that "Log note" still falls through to core's inline composer, and that isDiscard decides whether the parent record is reloaded. Both verified by mutation — reverting either fix fails exactly its own test. Assisted-by: Claude Opus 5
dnplkndll
force-pushed
the
19.0-mig-web_send_message_popup
branch
from
August 24, 2026 15:37
defae2b to
98f8c59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of web_send_message_popup from 18.0 to 19.0.
Migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0