Remove unused typing.cast imports - #151
Merged
Merged
Conversation
They became unused in b241c54 (turning FileHandleT and InodeT from NewTypes into type aliases), which made ruff's F401 fail CI on main. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ThomasWaldmann
force-pushed
the
fix-ruff-unused-cast
branch
from
September 3, 2026 11:01
3b3eeeb to
8eee1b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Testworkflow currently fails onmainat theLint (ruff)step:The imports became unused in b241c54 ("Turn FileHandleT and InodeT from
NewTypes into type aliases"), which removed the
cast()calls but left theimports behind. Since
fail-fast: true, this cancels the whole matrix, so notests have actually run on
mainsince then.With the three lines removed, the full matrix is green again (ruff, ruff
format, mypy, pyright, tests, docs on 3.10-3.14).
🤖 Generated with Claude Code