feat(widget): add simple and advance modes switching#775
Draft
effie-ms wants to merge 3 commits into
Draft
Conversation
|
E2E Examples — all passedAll examples passed in the latest run. |
E2E Playground resultsDetails
📥 Download full HTML report (open the run → Artifacts → |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
https://linear.app/lifi-linear/issue/EMB-451/enable-simple-and-advanced-jumper-modes-on-widget
Why was it implemented this way?
TBD:
Implementation:
The existing
SplitModeStorewas transformed into more generalHeaderTabsStore- to store all available and currently selected tabactiveTab. Each tab haslabel,mode,modeOptions.jumper-simpleandjumper-advancedresolve to 3 tabs (per design), each with a corresponding mode (default, swap, bridge, etc).NB: widget needs to be wider to store all 3 tabs.
Visual showcase (Screenshots or Videos)
TBA
Checklist before requesting a review