feat(widget): add private mode requiring send-to-wallet address#781
Draft
effie-ms wants to merge 1 commit into
Draft
feat(widget): add private mode requiring send-to-wallet address#781effie-ms wants to merge 1 commit into
effie-ms wants to merge 1 commit into
Conversation
|
E2E Examples — all passedAll examples passed in the latest run. |
E2E Playground resultsDetails
📥 Download full HTML report (open the run → Artifacts → |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
N/A
Why was it implemented this way?
Private mode is modeled as a
modeOptions.privateboolean flag rather than a newWidgetModevalue. This keeps theWidgetModeunion untouched (no exhaustivemodeswitch needs a new case) and letsprivatecompose orthogonally with the underlying mode.The Private header tab (in
jumper-simple) is now{ mode: 'split', modeOptions: { split: 'swap', private: true } }— it keeps its swap-only behavior and additionally forces the "Send to wallet" recipient. A smallusePrivateModehook (mirroringuseSplitMode/useSwapOnly) reads the flag from the active tab, falling back to root config. The requirement is enforced through the existingrequiredToAddresspath inuseToAddressRequirements, which already drives both the Send-to-wallet "Required" label and the disabled Review button — so no extra branching was needed.Visual showcase (Screenshots or Videos)
N/A
Checklist before requesting a review