Fix uncompressed ORC seek at logical stream end - #272
Open
byronellis wants to merge 6 commits into
Open
Conversation
Overlay ORC 1.8.2 InStream in the Spark 3.1 shaded runtime so a logical stream end at a non-final disk-range boundary is accepted. Add a regression test against the relocated runtime class. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Always apply the Spark 3.1 build configuration on the backport branch, compile the ORC nohive overlay against its provided APIs, and make the packaged-runtime regression sensitive to a gap after the stream boundary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the unrelated past-end seek guard and mark each intentional divergence in the ORC 1.8.2 source overlay. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment on lines
+213
to
+221
| boolean isLogicalEnd = desired == length && positionFile == curRange.getEnd(); | ||
| if (curRange.getOffset() <= positionFile | ||
| && (isLogicalEnd | ||
| || (curRange.next == null | ||
| ? positionFile <= curRange.getEnd() | ||
| : positionFile < curRange.getEnd()))) { | ||
| position = desired; | ||
| setCurrent(curRange, true); | ||
| return; |
mkuchenbecker
approved these changes
Aug 17, 2026
Exclude the resolved ORC dependency from the normal shadow merge, re-add it without InStream classes, and remove inherited key and IV debug logging from the overlay. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing Done
🤖 Generated with GitHub Copilot CLI