chore(protocol): bump submodule to v1.46.4 (DebugMessage) and regenerate stubs#689
Open
toubatbrian wants to merge 6 commits into
Open
chore(protocol): bump submodule to v1.46.4 (DebugMessage) and regenerate stubs#689toubatbrian wants to merge 6 commits into
toubatbrian wants to merge 6 commits into
Conversation
Submodule livekit-protocol/protocol: 0bb4e41 -> b89c3a7 (v1.46.3). Notable additions picked up in the regen: - agent_session: CustomEvent message + AgentSessionEvent.custom_event field (livekit/protocol#1588). - analytics: FeatureUsageInfo.KRISP_VIVA enum value. - room: RoomParticipantIdentity.revoke_token_ts field. - sip: CreateSIPParticipantRequest.{sip_request_uri,sip_to_header, sip_from_header} fields. Generated with protoc 25.1 to match build-protocol.yml.
toubatbrian
requested review from
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
The previous commit (3c7bae2) hand-regenerated the .py/.pyi stubs but never staged the submodule pointer bump itself. The build-protocol.yml bot then re-ran generate_proto.sh against the still-recorded 0bb4e41 submodule and overwrote my CustomEvent stubs (because they didn't match the actually-committed submodule state). Bot was right; my commit was internally inconsistent. Bump the submodule pointer for real (0bb4e41 -> b89c3a7, v1.46.3) so the bot's next regen produces stubs that actually include AgentSessionEvent.custom_event + CustomEvent. Co-authored-by: Cursor <cursoragent@cursor.com>
chenghao-mou
approved these changes
May 26, 2026
…9 -> 1.1.10 Picks up livekit/protocol#1593 which renames AgentSessionEvent.custom_event (field 21) -> AgentSessionEvent.debug_message and renames CustomEvent -> DebugMessage (drops the `type` field; payload only). Field number is unchanged. Bot will regenerate the Python stubs against the new submodule pointer. Co-authored-by: Cursor <cursoragent@cursor.com>
toubatbrian
changed the title
toubatbrian
added a commit
to livekit/agents
that referenced
this pull request
May 27, 2026
…_emit_debug_message Picks up livekit/protocol#1593 which renamed the agent-session event before any consumer shipped it. The message is repositioned as an internal debug/trace channel surfaced only to the debugger/recorder (e.g. agents-cli), not to user code. Proto change (mechanical rename): - AgentSessionEvent.custom_event -> AgentSessionEvent.debug_message (field 21) - agent_pb.CustomEvent (str type, Struct payload) -> agent_pb.DebugMessage (Struct payload) Surface change: - AgentSession.emit_custom_event(event_type, payload) -> AgentSession._emit_debug_message(payload) - underscore prefix + `:meta private:` docstring marker signal: not for user code - type discriminator dropped; callers just emit a JSON payload - EventTypes literal "custom_event" -> "debug_message" - SessionHost._on_custom_event -> _on_debug_message Pin bump: `livekit-protocol>=1.1.9` -> `>=1.1.10` to pick up DebugMessage. (CI type-check is blocked until livekit/python-sdks#689 merges and a new livekit-protocol release is cut to PyPI.) Drive-by deslop on the helper body: - `from google.protobuf...` imports lifted to module scope (avoids the no-inline-imports convention warning). - Dropped the defensive `if payload:` + `dict(payload)` cast and the `ignore_unknown_fields=True` kwarg (Struct fields aren't user fields). - Trimmed the 12-line docstring + 3-line inline comment down to the one non-obvious line that documents *why* we use `super().emit`. ruff check + ruff format --check clean. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
livekit-protocol/protocolsubmodule pointer tov1.46.4and the package version to1.1.10so the nextlivekit-protocolPyPI release ships:AgentSessionEvent.debug_message(field 21) — replaces the never-shippedcustom_eventfrom v1.46.3DebugMessage(Struct payload, notypefield) — replacesCustomEventThe
build-protocol.ymlbot regenerateslivekit-protocol/livekit/protocol/agent_pb/agent_session*against the new pointer.Why a new release
livekit-protocol==1.1.9(current PyPI) was tagged beforelivekit/protocol#1593(the DebugMessage rename) merged, so it ships the now-removedCustomEventsymbol. Downstream consumers (livekit/agents#5855) needDebugMessageto land their refactor.Test plan
v1.46.4tag (4b09446)livekit/protocol/agent_pb/agent_session.pyi—DebugMessagesymbol present,CustomEventsymbol absentlivekit/agents#5855will pin>=1.1.10