Add cmake option for CAMP_USE_PLATFORM_DEFAULT_STREAM#205
Open
helloworld922 wants to merge 8 commits into
Open
Add cmake option for CAMP_USE_PLATFORM_DEFAULT_STREAM#205helloworld922 wants to merge 8 commits into
helloworld922 wants to merge 8 commits into
Conversation
Changes to the cmake option for default stream
4 tasks
white238
reviewed
Jun 4, 2026
Member
|
Used internally: https://github.com/llnl/camp/blob/56b194f3ea3d0e9d6e2f236de39a4886063e4968/include/camp/resource/hip.hpp#L187C5-L187C37 @helloworld922 , is the issue that we do not have a CMAKE variable to define it? |
Author
|
Yes, the define is supposed to be user defined if they want to use default streams, but unless you properly forward the compiler define to all downstream dependencies you either end up with an ODR violation and/or not having the correct behavior of which stream kernels are being run on. This just makes sure that the define is baked into the installed RAJA headers so everyone picks up a consistent definition. |
trws
reviewed
Jun 9, 2026
MrBurmark
previously approved these changes
Jun 23, 2026
adayton1
previously approved these changes
Jun 23, 2026
MrBurmark
reviewed
Jun 23, 2026
rhornung67
previously approved these changes
Jun 23, 2026
adayton1
reviewed
Jun 23, 2026
MrBurmark
approved these changes
Jun 23, 2026
adayton1
approved these changes
Jun 23, 2026
rhornung67
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.