Skip to content

DM-53379: Add PPDB Dev Cloud SQL#819

Merged
dspeck1 merged 9 commits into
mainfrom
tickets/DM-53379-cloudsql
Jun 17, 2026
Merged

DM-53379: Add PPDB Dev Cloud SQL#819
dspeck1 merged 9 commits into
mainfrom
tickets/DM-53379-cloudsql

Conversation

@dspeck1

@dspeck1 dspeck1 commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Add Cloud SQL to PPDB dev project.

@dspeck1 dspeck1 force-pushed the tickets/DM-53379-cloudsql branch from 6f53eda to a357996 Compare May 19, 2026 21:55
@dspeck1 dspeck1 requested a review from JeremyMcCormick May 19, 2026 21:55
Comment thread environment/deployments/ppdb/cloudsql/variables.tf Outdated
@JeremyMcCormick

Copy link
Copy Markdown

@dspeck1 Does the PPDB environment being set to dev in this config represent a default that is overridden for other environments when the plan is generated?

@dspeck1 dspeck1 force-pushed the tickets/DM-53379-cloudsql branch from f2908b0 to f95256d Compare May 21, 2026 15:12
@dspeck1

dspeck1 commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

@dspeck1 Does the PPDB environment being set to dev in this config represent a default that is overridden for other environments when the plan is generated?

Thanks for catching that. The state prefix was hard coded to dev and updated to use a variable. It is fixed now.

Related to this there will be a tfvar per environment. After we get dev setup I will add tfvars files for int and prod.

@JeremyMcCormick JeremyMcCormick left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dspeck1 and I went over this and it looks good as a starting point for Cloud SQL config. This is only touching the dev environment for now; there will be subsequent PRs for int/prod.

@dspeck1 dspeck1 force-pushed the tickets/DM-53379-cloudsql branch from f95256d to f96702e Compare June 17, 2026 13:28
@dspeck1 dspeck1 merged commit 996b1ab into main Jun 17, 2026
2 checks passed
@dspeck1 dspeck1 deleted the tickets/DM-53379-cloudsql branch June 17, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants