Skip to content

feat(mapview): add compassEnabled prop for iOS and Android#74

Open
KirillKaverin wants to merge 1 commit into
lugg:mainfrom
KirillKaverin:feature/compass
Open

feat(mapview): add compassEnabled prop for iOS and Android#74
KirillKaverin wants to merge 1 commit into
lugg:mainfrom
KirillKaverin:feature/compass

Conversation

@KirillKaverin
Copy link
Copy Markdown

Summary

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Test Plan

Screenshots / Videos

Checklist

  • I tested on iOS
  • I tested on Android
  • I tested on Web
  • I updated the documentation (if needed)

@lodev09
Copy link
Copy Markdown
Collaborator

lodev09 commented May 15, 2026

LGTM overall — implementation cleanly follows the existing pattern for boolean prop toggles (private field, equality short-circuit on Android, applyProps wiring on iOS, inclusion in applyUiSettings). Codegen + TS types + docs all consistent.

Two notes:

  • Behavior change on iOS Google Maps. GMSMapView.settings.compassButton defaults to NO upstream; with compassEnabled defaulting to true, existing apps using the Google provider on iOS will start showing the compass button after upgrading. Likely intended (matches Apple/Android defaults), but worth calling out in the PR description / changelog.
  • Web not updated. src/MapView.web.tsx doesn't handle the new prop. rotateEnabled has the same gap, so not a new regression — fine to defer.

Nit: PR body Summary / Test Plan are empty per the template in AGENTS.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants