refactor(eip712): rename EIP712Repository.signTypedDataEIP712 to signTypedData#52
Merged
Merged
Conversation
…TypedData The public repository method consumed by the wallet is renamed back to `signTypedData`. Internal signing utilities (`signTypedDataEIP712`, `...DigestWithKey`, `...WithRawKey`) and the error-source tag keep the EIP-712 suffix.
Comp0te
approved these changes
Jun 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the public
EIP712Repositorysigning method consumed by the wallet fromsignTypedDataEIP712back tosignTypedData.This reverts the public-facing part of the naming introduced in #47, restoring the original
signTypedDatamethod name on the repository contract (IEIP712Repository+EIP712Repository).Scope
IEIP712Repository.signTypedData,EIP712Repository.signTypedData, JSDoc and the corresponding unit test.utils/eip712/sign.ts(signTypedDataEIP712,signTypedDataEIP712DigestWithKey,signTypedDataEIP712WithRawKey), the...Utilalias import and the'signTypedDataEIP712'error-source tag.Verification
tsc --noEmitcleaneslintcleanjest— all eip712 suites pass (90 tests)