Skip to content

chore(deps): remove unused pnpm overrides#8973

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
chore/remove-unused-pnpm-overrides
Apr 29, 2026
Merged

chore(deps): remove unused pnpm overrides#8973
sriramveeraghanta merged 1 commit intopreviewfrom
chore/remove-unused-pnpm-overrides

Conversation

@sriramveeraghanta
Copy link
Copy Markdown
Member

@sriramveeraghanta sriramveeraghanta commented Apr 29, 2026

Summary

  • Removed four pnpm.overrides entries that no workspace package depends on, directly or transitively: js-yaml, happy-dom, tar-fs, @isaacs/brace-expansion.
  • Verified each had zero resolved entries in pnpm-lock.yaml before removal — they were dead weight pinning versions for packages not in the dependency tree.
  • Regenerated lockfile with pnpm install --lockfile-only. The only change beyond removing the override declarations is happy-dom's optional peer of vitest reverting to '*' (no resolved package affected).

Test plan

  • CI passes on the regenerated lockfile
  • pnpm install completes cleanly on a fresh checkout

Summary by CodeRabbit

  • Chores
    • Removed fixed version constraints from package dependency overrides, allowing more flexible dependency resolution.

Drop four overrides that no package in the workspace depends on
(direct or transitive): js-yaml, happy-dom, tar-fs, and
@isaacs/brace-expansion. Verified against pnpm-lock.yaml — no resolved
entries existed, so the overrides were dead weight.
Copilot AI review requested due to automatic review settings April 29, 2026 12:27
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

📝 Walkthrough

Walkthrough

The pull request removes version override constraints for four dependencies from pnpm.overrides in package.json: js-yaml, happy-dom, tar-fs, and @isaacs/brace-expansion. This allows pnpm to use dependency resolution without forced version pinning for these packages.

Changes

Cohort / File(s) Summary
Dependency Overrides
package.json
Removed pnpm.overrides declarations for js-yaml, happy-dom, tar-fs, and @isaacs/brace-expansion (4 lines deleted).

Possibly related PRs

Poem

🐰 Four chains now released from their rigid grasp,
Version constraints loosened, dependencies unclasped,
The forest of packages hops wild and free,
No forced versions blocking what they long to be! 🌿✨

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description provides a clear summary of changes, test plan, and verification steps, but does not explicitly follow the repository's description template structure. Consider restructuring the description to match the template by adding explicit sections for 'Type of Change' (e.g., selecting 'Code refactoring' or 'Improvement'), and optionally 'References' linking to issue #8973.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: removing unused pnpm overrides from package.json dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-unused-pnpm-overrides

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unused pnpm.overrides entries from the workspace root configuration and syncs the lockfile accordingly, reducing unnecessary version pinning in the monorepo’s dependency management.

Changes:

  • Removed four unused pnpm.overrides entries (js-yaml, happy-dom, tar-fs, @isaacs/brace-expansion) from package.json.
  • Updated pnpm-lock.yaml to reflect the removed overrides and the regenerated lockfile state.
  • Lockfile shows vitest’s optional peer requirement for happy-dom reverting to '*' (peer range only; no resolved happy-dom entry present).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Drops unused pnpm.overrides entries to avoid pinning packages not in the dependency tree.
pnpm-lock.yaml Removes the corresponding lockfile overrides and reflects lockfile-only regeneration effects.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@sriramveeraghanta sriramveeraghanta merged commit a62fe8a into preview Apr 29, 2026
17 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/remove-unused-pnpm-overrides branch April 29, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants