chore: replace node-fetch and https-proxy-agent with undici - #743
Draft
benmccann wants to merge 1 commit into
Draft
chore: replace node-fetch and https-proxy-agent with undici#743benmccann wants to merge 1 commit into
node-fetch and https-proxy-agent with undici#743benmccann wants to merge 1 commit into
Conversation
benmccann
marked this pull request as draft
June 30, 2024 04:22
benmccann
changed the title
node-fetch and https-proxy-agent with undici
benmccann
force-pushed
the
fetch
branch
4 times, most recently
from
July 13, 2024 18:42
bb41cde to
fe419c3
Compare
benmccann
force-pushed
the
fetch
branch
2 times, most recently
from
July 19, 2024 20:28
4b2cef6 to
974b934
Compare
benmccann
force-pushed
the
fetch
branch
6 times, most recently
from
September 9, 2024 16:45
7e1c33f to
292931f
Compare
2 tasks
Collaborator
|
@pi0 Can you please provide a review of this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #876
Added in Node 16.15.0. This library already requires Node 18
undiciis the officialfetchimplementation, which is bundled with Node. Whilefetchis available as a Node global, unfortunatelyProxyAgentis not yet available in Node: nodejs/node#43187. Nonetheless I've switched this PR to useundiciin favor ofhttps-proxy-agentbecause it will eventually be the standard and we're replacing two dependencies with oneNock doesn't seem to be working. Might need to switch to: https://x.com/mattpocockuk/status/1841074839446003927?t=nPivnaYBwxq9AQ51N2zkUg&s=19
Also might need to take a look at the concerns in #747 (comment)