Improve contrast between optional argument text and background#187
Open
dstansby wants to merge 2 commits intomatplotlib:mainfrom
Open
Improve contrast between optional argument text and background#187dstansby wants to merge 2 commits intomatplotlib:mainfrom
dstansby wants to merge 2 commits intomatplotlib:mainfrom
Conversation
QuLogic
reviewed
Apr 17, 2026
QuLogic
reviewed
Apr 30, 2026
|
|
||
|
|
||
| \newcommand{\optional}[1]{\textcolor{gray}{#1}} | ||
| # 89, 89, 89 is the lightest colour that still gives a good contrast ratio with the white background |
Member
There was a problem hiding this comment.
Suggested change
| # 89, 89, 89 is the lightest colour that still gives a good contrast ratio with the white background | |
| % 89, 89, 89 is the lightest colour that still gives a good contrast ratio with the white background |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138 (I think). To choose the colour I used https://webaim.org/resources/contrastchecker/ to pick the lightest colour that still passes the accessibility checks (which seem to be a contrast ratio of at least 7:1)