Move pointer/reference rejection to Sema#8436
Merged
Merged
Conversation
This is a refactoring to move the rejection of pointer and reference types into Sema rather than rejecting it during parsing. This has a few consequences and benefits. The consequence as seen in the changes to the cpp-errors tests are that we don't see pointer use errors in cases where a parser error prevents sema code from executing (as seen in operator cases). The benefit is that this also intercepts pointer and reference types that are deduced (via templates, auto or decltype).
bogner
approved these changes
May 11, 2026
| @@ -0,0 +1,65 @@ | |||
| // RUN: %dxc -T cs_6_0 %s 2>&1 | FileCheck %s --check-prefix=COMPILE | |||
Collaborator
There was a problem hiding this comment.
Can we use CHECK-COMPILE for the prefix? It's generally clearer to use CHECK-<something> than just <something>
../tools/clang/test/SemaHLSL/template-implicit-this-sfinae.hlsl
bob80905
reviewed
May 15, 2026
| float foo; | ||
| void * operator new(int size) { // expected-error {{overloading 'operator new' is not allowed}} expected-error {{pointers are unsupported in HLSL}} | ||
| return (void *)0; // expected-error {{pointers are unsupported in HLSL}} expected-error {{cannot convert from 'literal int' to 'void *'}} expected-warning {{'operator new' should not return a null pointer unless it is declared 'throw()'}} | ||
| S operator new(int size) { // expected-error {{overloading 'operator new' is not allowed}} |
Collaborator
There was a problem hiding this comment.
For this file, I understand why the 2nd error diagnostic is being removed, but why do the types need to be changed?
Collaborator
Author
There was a problem hiding this comment.
Sema rejecting the return type causes the compiler to skip processing or surfacing diagnostics for the rest of the declaration, so if the return type is a pointer, no further diagnostics are generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactoring to move the rejection of pointer and reference types into Sema rather than rejecting it during parsing. This has a few consequences and benefits.
The consequence as seen in the changes to the cpp-errors tests are that we don't see pointer use errors in cases where a parser error prevents sema code from executing (as seen in operator cases).
The benefit is that this also intercepts pointer and reference types that are deduced (via templates, auto or decltype).