Add "Advanced Audit Policy" Rule Handling#1556
Draft
FrederickGeek8 wants to merge 2 commits into
Draft
Conversation
No code has been changed. This new module will be modified for "Advanced" audit policy parsing in another commit. Making a copy here makes the changes in subsequent commits more obvious.
This assumes a certain stability in the RawString text, but the pattern seems to hold for now.
Author
|
@microsoft-github-policy-service agree company="Full Spectrum Software LLC" |
Author
|
@MrAutomater can you (or someone else) take a look at this and tell me if it's a reasonable approach for addressing #1533? If I get a thumbs up for this general approach then I can work on adding tests, rebasing, and updating generated files. Thanks! |
Collaborator
|
I am on vacation this week, but I can take a look when I get back next week and let you know
Thanks,
Jerry Martin
…________________________________
From: Frederick Morlock ***@***.***>
Sent: Monday, 22 June 2026 12:30:36
To: microsoft/PowerStig ***@***.***>
Cc: Jerry Martin ***@***.***>; Mention ***@***.***>
Subject: Re: [microsoft/PowerStig] Add "Advanced Audit Policy" Rule Handling (PR #1556)
[https://avatars.githubusercontent.com/u/774597?s=20&v=4]FrederickGeek8 left a comment (microsoft/PowerStig#1556)<#1556 (comment)>
@MrAutomater<https://github.com/MrAutomater> can you (or someone else) take a look at this and tell me if it's a reasonable approach for addressing #1533<#1533>?
If I get a thumbs up for this general approach then I can work on adding tests, rebasing, and updating generated files.
Thanks!
—
Reply to this email directly, view it on GitHub<#1556?email_source=notifications&email_token=AICAG35DVAHXEAP7T3BJIN35BFULZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXGEYDKNJQGIYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4771055020>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AICAG34FYYO3JNUNZVWIMDL5BFULZAVCNFSNUABFKJSXA33TNF2G64TZHMYTGMRRGAYDKMRZHNEXG43VMU5TINRYGUYTQMJVGM42C5QC>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/AICAG3ZJZMAH5Q5G3Z4GQWD5BFULZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXGEYDKNJQGIYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android<https://github.com/notifications/mobile/android/AICAG343N7Y33E2QVWPHQP35BFULZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXGEYDKNJQGIYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today!
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description:
This PR adds proper handling for "Advanced Audit Policy" rules that were not being applied (as was reported in #1533). These rules appear in Windows 10, 11, and Server STIGs are currently are no-ops. In essence, this PR is just changing the parsing logic of AuditPolicyRule to support the new language used by those items.
This PR is marked as "WIP", but please do a review and help me answer some PowerStig contribution-specific questions :)
AuditPolicyRuleConvertinto a new file rather than overload the parsing ofAuditPolicyRuleConvert. Do we want to keep this delineation or merge the two?AuditPolicyRuleAdvancedConvert". What should we change it to?This Pull Request (PR) fixes the following issues:
This PR fixes #1533 (and other related STIGs like Win11 and WinServer)
Task list:
I'd appreciate answers to my "WIP blocking" questions above and other feedback on this approach. Thanks!