Add shell exit tool result metadata#314
Merged
Merged
Conversation
roblourens
previously requested changes
Jul 7, 2026
| /** Working directory where the shell command was executed */ | ||
| cwd?: string; | ||
| /** Output preview associated with the shell command, if available */ | ||
| outputPreview?: string; |
Member
There was a problem hiding this comment.
Should we separate this so that terminal output can be streamed?
Contributor
Author
There was a problem hiding this comment.
Not sure if we should take streaming as part of ToolResultShellExitContent in the first place🧐
Maybe under something new like ToolResultShellProgressContent?
I was thinkingToolResultShellExitContent should ideally be for when shell comes back after some kind of exit/completion.
anthonykim1
marked this pull request as draft
July 7, 2026 22:56
roblourens
reviewed
Jul 7, 2026
connor4312
reviewed
Jul 8, 2026
anthonykim1
marked this pull request as draft
July 8, 2026 16:22
anthonykim1
marked this pull request as ready for review
July 8, 2026 17:16
connor4312
reviewed
Jul 8, 2026
connor4312
reviewed
Jul 8, 2026
connor4312
approved these changes
Jul 8, 2026
colbylwilliams
added a commit
that referenced
this pull request
Jul 8, 2026
Brings in the MCP server start/stop actions (`session/mcpServerStartRequested` / `session/mcpServerStopRequested`, #319), the optional `version` field on `PluginCustomization` (#317), the `ToolResultTerminalCompleteContent` shell exit tool-result metadata (#314), and the guide/spec docs accuracy pass (#312). Resolved conflicts: - The six CHANGELOGs — kept main's new bullets and appended the canvas bullet under the current unreleased section (matching main's per-file placement). - `clients/rust/crates/ahp/src/reducers.rs` — merged the state-import list so it keeps both `CanvasState` and main's new `McpServer*State` types (cargo fmt re-wrapped). - `docs/specification/subscriptions.md` — kept main's edits (dropped `unsubscribe` from the channel-scoped command row; reworded the resource-watch id as "receiver-assigned") and re-added the canvas rows. Regenerated all client artifacts and schemas; the canvas channel still registers its actions at spec 0.5.2 and PROTOCOL_VERSION is unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream changes from: microsoft/vscode#323922
Also seems like we were behind on
npm run generatefor changeset related PRs?